New FieldFormatter to show CMIS browser in Entity

1. +++ b/config/schema/cmis.schema.yml
   @@ -12,3 +12,6 @@ field.widget.settings.cmis_field_widget:
   +    show_breadcrumb:
   

   Nope. This is the schema of the widget.

   You need to make a schema for the field formatter.

2. +++ b/src/CmisBrowser.php
   @@ -275,45 +285,66 @@ class CmisBrowser {
   +    if ($this->connection->hasAllowableActionById($this->current->getId(), Action::CAN_CREATE_FOLDER)) {
   

   $this->current->getId() put into a variable.

3. +++ b/src/CmisBrowser.php
   @@ -275,45 +285,66 @@ class CmisBrowser {
   +        if (strpos($route_name, 'browser') !== FALSE) {
   

   A comment on why this if would be appreciated.

4. +++ b/src/CmisBrowser.php
   @@ -336,23 +367,24 @@ class CmisBrowser {
   +    if (strpos($route_name, 'browser') !== FALSE || ($this->additionalSettings && $this->additionalSettings['show_breadcrumb'])) {
   

   This needs a comment.

5. +++ b/src/CmisElement.php
   @@ -120,33 +121,8 @@ class CmisElement {
        $link_options = [];
   

   Unused variable.

6. +++ b/src/CmisElement.php
   @@ -120,33 +121,8 @@ class CmisElement {
   +
   

   Uneeded empty line.

7. +++ b/src/CmisElement.php
   @@ -262,6 +240,58 @@ class CmisElement {
   +
   

   Uneeded empty line.

8. +++ b/src/CmisElement.php
   @@ -290,9 +320,9 @@ class CmisElement {
   +    if ($this->rootId != $this->element->getId() && $cmis_connection_api->hasAllowableActionById($this->element->getId(), Action::CAN_DELETE_OBJECT)) {
   

   Put $this->element->getId() in a variable to avoid several calls.

9. +++ b/src/Plugin/Field/FieldFormatter/CmisFieldBrowser.php
   @@ -0,0 +1,103 @@
   +      '#type' => 'checkbox',
   

   #type first please :)

10. +++ b/src/Plugin/Field/FieldFormatter/CmisFieldBrowser.php
    @@ -0,0 +1,103 @@
    +    $summary[] = ($settings['show_breadcrumb'] == 1) ? $this->t('Show breadcrumb : Yes') : $this->t('Show breadcrumb : No');
    

    No space before punctuation with double points in english :)

11. +++ b/src/Plugin/Field/FieldFormatter/CmisFieldBrowser.php
    @@ -0,0 +1,103 @@
    +    $elements['#cache']['max-age'] = 0;
    +    $elements['#cache']['contexts'] = [];
    +    $elements['#cache']['tags'] = [];
    

    I understand that there is currently no cache mecanism possible because the content displayed inside is from an external source.

    Maybe creating a cache tag per folder ID and flushing this cache tag when modifying a folder content. But the current code base will not help to do that.

    To avoid preventing the whole page to be cacheable, maybe we can do a lazy_builder approach. See https://github.com/Drupal-FR/site-drupalfr/blob/8.x-1.x/www/modules/cust...

12. +++ b/src/Plugin/Field/FieldFormatter/CmisFieldBrowser.php
    @@ -0,0 +1,103 @@
    +    $config_path = explode('/', $item->get('path')->getValue(), -1);
    

    -1 needs a comment.

13. +++ b/src/Plugin/Field/FieldWidget/CmisFieldWidget.php
    @@ -10,12 +10,15 @@ use Drupal\Core\Field\WidgetBase;
    +use Drupal\cmis\Controller\CmisRepositoryController;
    

    Unused statement.

14. +++ b/src/Plugin/Field/FieldWidget/CmisFieldWidget.php
    @@ -10,12 +10,15 @@ use Drupal\Core\Field\WidgetBase;
    + *   module = "cmis",
    

    Why add this? It does not seem to be in the annotation.

Now, I will manually test the patch.

Also, here is a rebased patch, because patch from comment 12 didn't apply any more.

I made some changes of the previous review.

Seen together. When the show breadcrumb option is unchecked, it is ok on the first display of the browser. But when going into a folder, then the breadcrumb is displayed again.

Schema.yml is wrong.

Seen together about the show breadcrumb settings not transmitted. I have created a child issue because currently with the module architecture, it is difficult/impossible to do better in a generic way.

Going to merge the patch.