Fix coding standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3161988-5-coding-standards.patch | 7.23 KB | jrglasgow |
| #3 | 3161988-3.patch | 9.26 KB | siddhant.bhosale |
Fix coding standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3161988-5-coding-standards.patch | 7.23 KB | jrglasgow |
| #3 | 3161988-3.patch | 9.26 KB | siddhant.bhosale |
Comments
Comment #2
siddhant.bhosale commentedComment #3
siddhant.bhosale commentedHi, I have fixed the possible coding standard issues.
There are few places where there are unused variables. The maintainer needs to verify that why they were used in the first place.
For example :
Also for DI we have another issue, @see https://www.drupal.org/project/site_audit/issues/3163674,So DI fixes should be done in other issue and not the coding standard.
Please review.
Comment #4
siddhant.bhosale commentedComment #5
jrglasgow commentedI re-rolled the patch in #3 so it will apply now I will test
Comment #7
jrglasgow commentedI have tested and the new patch works without causing any issues - committed