Hi

I would like to throw the idea to add Ludwig module support to this readily awesome barcodes module so that it can become more awesome.

A lot of us are using cpanel with very limited access to the server, a lot of the times my clients already have their own hosting server so it is troublesome to have to configure this barcode module every time without access to composer.

Therefore, it would be very great if this awesome barcodes module could also use ludwig in addition to composer.

Thank you.

CommentFileSizeAuthor
#4 barcodes-ludwig-integration-3160901-4.patch462 bytesdevad

Comments

klauq created an issue. See original summary.

sanduhrs’s picture

Version: 8.x-1.10 » 2.0.x-dev
devad’s picture

Title: Ludwig support » Barcodes - Ludwig integration
devad’s picture

Issue summary: View changes
StatusFileSize
new462 bytes

Hi @sanduhrs and other maintainers of Barcodes module.

I am Ludwig module co-maintainer.

I would like to support idea that you add Ludwig integration into Barcodes module by providing ludwig.json file inside your module's root folder in all future Barcodes module 2.x.x releases.

This would make the life of users not friendly with Composer much easier. :)

Here is the full list of (currently) required libraries for Barcodes module installation from composer report:

  - Installing tecnickcom/tc-lib-color (1.12.15): Downloading (100%)
  - Installing tecnickcom/tc-lib-barcode (1.16.1): Downloading (100%)

So, tecnickcom/tc-lib-color library is a dependency of tecnickcom/tc-lib-barcode, so both these libraries have to be added to ludwig.json file in order for Barcodes module to work nicely with Ludwig.

{
  "require": {
    "tecnickcom/tc-lib-color": {
      "version": "v1.12.15",
      "url": "https://github.com/tecnickcom/tc-lib-color/archive/1.12.15.zip"
    },
    "tecnickcom/tc-lib-barcode": {
      "version": "v1.16.1",
      "url": "https://github.com/tecnickcom/tc-lib-barcode/archive/1.16.1.zip"
    }
  }
}

Maintenance would not be a big issue in this case. Once new Barcodes module release is out and if library dependencies has changed - ludwig.json file should be updated to new library requirements by Barcodes module maintainers just like composer.json file is updated.

Here is the patch. I created it fo 2.0.x-dev, but it should fit for 8.x-1.x-dev also.

It's pity that Barcode module tests are not enabled. :)

devad’s picture

devad’s picture

devad’s picture

Status: Active » Needs review

  • sanduhrs committed bb54a95 on 2.0.x authored by devad
    Issue #3160901 by devad: Barcodes - Ludwig integration
    

  • sanduhrs committed a1da88e on 8.x-1.x authored by devad
    Issue #3160901 by devad: Barcodes - Ludwig integration
    
sanduhrs’s picture

Status: Needs review » Fixed

Committed, thanks for the patch ;)

devad’s picture

Welcome. Thanks for commit and new releases!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.