Currently, when you add custom css, the settings are saved in 2 places: my_theme.settings.yml and css_editor.theme.my_theme.yml.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | css_editor-revert_config_is_saved_seperate-3160715-9.patch | 2.49 KB | joseph.olstad |
| #6 | 3160715-6.patch | 1.49 KB | jeroent |
| #3 | 3160715-3.patch | 2.49 KB | jeroent |
| #2 | 3160715-2.patch | 2.75 KB | jeroent |
Comments
Comment #2
jeroentComment #3
jeroentComment #5
podarokmerged, thank you.
@JeroenT - would be also cool to add upgrade path and cleanup old config from css_editor leftovers
Comment #6
jeroentSince the data is already saved in another config file, we can probably just remove those keys from [theme].settings.yml.
Comment #7
joseph.olstadThis patch broke the css_editor release 8.x-1.3
reverting this patch fixes the problem of saving the 'css editor' mode checkbox
NOTE:
using a bootstrap based theme
Comment #8
joseph.olstadPlease revert the above commit and tag a new release 8.x-1.4
Comment #9
joseph.olstadhere is the patch to revert this (for our composer.json patches section)
Comment #10
joseph.olstad@podarok
please fix this issue , see the patch I provided which reverts the broken code.
Comment #11
jeroentBack to needs review for the patch in #6.
Comment #12
jeroentComment #13
joseph.olstadreviewing patch 6 now
Comment #14
joseph.olstadhmm, patch 6 doesn't seem to cut it for me.
Comment #15
joseph.olstadThis issue is fixed now in the 2.0.1 release so if you're using the 2.0.1+ release you can ignore this patch.