Currently, when you add custom css, the settings are saved in 2 places: my_theme.settings.yml and css_editor.theme.my_theme.yml.

Comments

JeroenT created an issue. See original summary.

jeroent’s picture

Status: Active » Needs review
StatusFileSize
new2.75 KB
jeroent’s picture

StatusFileSize
new2.49 KB

  • podarok committed 029297b on 8.x-1.x authored by JeroenT
    Issue #3160715 by JeroenT: Config is saved in theme config and separate...
podarok’s picture

Category: Bug report » Task
Status: Needs review » Needs work

merged, thank you.

@JeroenT - would be also cool to add upgrade path and cleanup old config from css_editor leftovers

jeroent’s picture

Status: Needs work » Needs review
StatusFileSize
new1.49 KB

Since the data is already saved in another config file, we can probably just remove those keys from [theme].settings.yml.

joseph.olstad’s picture

Status: Needs review » Needs work

This patch broke the css_editor release 8.x-1.3

reverting this patch fixes the problem of saving the 'css editor' mode checkbox

NOTE:

using a bootstrap based theme

joseph.olstad’s picture

Please revert the above commit and tag a new release 8.x-1.4

joseph.olstad’s picture

here is the patch to revert this (for our composer.json patches section)

joseph.olstad’s picture

@podarok

please fix this issue , see the patch I provided which reverts the broken code.

jeroent’s picture

Back to needs review for the patch in #6.

jeroent’s picture

Status: Needs work » Needs review
joseph.olstad’s picture

reviewing patch 6 now

joseph.olstad’s picture

hmm, patch 6 doesn't seem to cut it for me.

joseph.olstad’s picture

Status: Needs review » Closed (outdated)

This issue is fixed now in the 2.0.1 release so if you're using the 2.0.1+ release you can ignore this patch.