Problem/Motivation

There is a configuration option at the bottom of the form for the Google CSE Search plugin that offers a checkbox labeled "Use advanced, ad-free version, search engine (You will need a paid account with Google. If enabled, search results will be fetch using Adv engine."

There are two problems with this:

  1. The "Adv engine" most likely refers to the XML results API for Google Site Search, which has since been retired (see https://stackoverflow.com/a/45902032. The closest current equivalent is the Custom Search JSON API, which is not currently supported by this module (see #3156181: Add support for Site Restricted Search API).
  2. The use_adv configuration parameter that is set by this form input does not have any functional effect in the rest of the module. See comment on line 172 of src/Plugin/Search/GoogleCSESearch.php:

// @todo $condition is an unused variable verify and remove it.

Proposed resolution

Remove the option on the plugin configuration form, and remove all references in code to the use_adv configuration value.

User interface changes

  • Remove "Google CSE Advanced" section from plugin configuration form

Data model changes

  • Remove use_adv configuration key

Comments

gravelpot created an issue. See original summary.

gravelpot’s picture

Issue summary: View changes
gravelpot’s picture

Assigned: Unassigned » gravelpot
mark_fullmer’s picture

Issue tags: +Global2020
jeff cardwell’s picture

StatusFileSize
new4.73 KB
lreynaga’s picture

Status: Active » Reviewed & tested by the community

All references to variable use_adv have been removed, as well as the checkbox and fieldset from the form. No references to these were made on tests, so there is nothing to refactor there. Search is working fine for me both on blocks and pages.

Nice work!

  • lreynaga committed 9fc10d1 on 8.x-3.x authored by Jeff Cardwell
    Issue #3159988 by Jeff Cardwell, gravelpot: Remove references to "Google...
lreynaga’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.