The core database drivers must naturally return results in the expected order, but this is not a guarantee. SQL Server does not always return the views ordered by nid. Adding a sort to the test view allows the test to pass on more databases.

CommentFileSizeAuthor
#2 3159382-2.patch812 bytesBeakerboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Beakerboy created an issue. See original summary.

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Assigned: Beakerboy » Unassigned
Status: Active » Needs review
FileSize
3159382-2.patch812 bytes

Patch added for review.

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Title: Sort order not specified in view test_view_fieldapi, but rusults must be ordered by nid » Sort order not specified in view test_view_fieldapi, but results must be ordered by nid

Status: Needs review » Needs work

The last submitted patch, 2: 3159382-2.patch, failed testing. View results

Beakerboy’s picture

Beakerboy
Primary language English
Location Kentucky
CreditAttribution: Beakerboy as a volunteer commented
Status: Needs work » Needs review

Unrelated error. Changing back to “needs review”.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.
It is the same solution as for #3146016: Sort order not specified in view test_node_revision_uid, but results asserted to be in a specific order.
For me it is RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed 39aa6bf474 to 9.1.x and 377146dff3 to 9.0.x and 2f20396a08 to 8.9.x. Thanks!

Backported to 8.9.x to keep test stuff aligned.

  • alexpott committed 39aa6bf on 9.1.x 
    Issue #3159382 by Beakerboy: Sort order not specified in view...

  • alexpott committed 377146d on 9.0.x 
    Issue #3159382 by Beakerboy: Sort order not specified in view...

  • alexpott committed 2f20396 on 8.9.x 
    Issue #3159382 by Beakerboy: Sort order not specified in view...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.