Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

Assigned: waleedq » mohammed j. razem
rajab natshah’s picture

Assigned: mohammed j. razem » rajab natshah
Status: Active » Needs review

rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

#2664016: Adding a new batch set while the batch is running breaks batch order


Drupal coding standard and Drupal Practice check should pass

PHPCS, PHPCBF for both --standard=Drupal and --standard=DrupalPractice

Check Varbase Core Drupal coding standard

phpcbf --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/ 

phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/ 

Check Varbase Core Drupal Practice

phpcbf --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/

phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/
rajab natshah’s picture

rajab natshah’s picture

rajab@vardot-dev:/var/www/html/products/varbase_core$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/

rajab@vardot-dev:/var/www/html/products/varbase_core$ phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,theme,scss,css,info,txt,md,yml /var/www/html/products/varbase_core/

  • RajabNatshah committed 69664fe on 8.x-8.x
    Issue #3158756 by Mohammed J. Razem, waleedq: Improve Varbase...
rajab natshah’s picture

Status: Needs review » Needs work
An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /test/varbase8c1t1/docroot/core/install.php?rewrite=ok&profile=varbase&langcode=en&id=3&op=do_nojs&op=do
StatusText: OK
ResponseText: Drupal\Core\Config\PreExistingConfigException: Configuration objects (ds_extras.settings) provided by ds_extras already exist in active configuration in Drupal\Core\Config\PreExistingConfigException::create() (line 65 of /var/www/html/test/varbase8c1t1/docroot/core/lib/Drupal/Core/Config/PreExistingConfigException.php).
rajab natshah’s picture

Status: Needs work » Active
rajab natshah’s picture

The batch function will be called in the very late in the batch queue ..
and the code for importing configs will run first.
Then when a module is installed, it will find the config in the active config.
But also .. some other modules will not find some modules and configs will not be installed

To fix .. all should be changed to batch and put into the batch queue
I will revert the code
.. and only keep

foreach ($module_info_data['install'] as $module) {
  if (!\Drupal::moduleHandler()->moduleExists($module)) {
   \Drupal::service('module_installer')->install([$module], TRUE);
  }
}

instead of

\Drupal::service('module_installer')->install($module_info_data['install'], TRUE);

  • RajabNatshah committed 6716fb8 on 8.x-8.x
    Revert Issue #3158756: Improve Varbase installation memory consumption...

  • RajabNatshah committed b6e01a4 on 8.x-8.x
    Issue #3158756: Change the Drupal service module installer to install...
rajab natshah’s picture

Title: Improve Varbase installation memory consumption by batching "install" directives in .info.yml file » Change the Drupal service module installer to install only one module for all list of modules in the install info data

  • RajabNatshah committed 021ce37 on 9.0.x
    Issue #3158756: Change the Drupal service module installer to install...
rajab natshah’s picture

Assigned: rajab natshah » mohammed j. razem
Status: Active » Needs review
Issue tags: +varbase-8.8.6, +varbase-9.0.0
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

Status: Needs review » Fixed

  • RajabNatshah committed d56719a on 9.0.x
    Issue #3158756: Change the Drupal service module installer to install...

  • RajabNatshah committed 0fdfd8e on 8.x-8.x
    Issue #3158756: Change the Drupal service module installer to install...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.