Missing parameter $nameIdValueReq on saml_sp_Auth::login()

Turned into a bigger patch because _lastRequestID and _lastRequest are private now and can't be written to directly.

I removed the saml_sp_AuthnRequest class because it seemed redundant and called the parent::login() and got the variables filled in different ways.

@jrglasgow Thanks for the quick response.

I moved the debugging that saml_sp_AuthnRequest , sorry I should have mentioned it was a end of the day rush to post the code, so didn't lose it, just moved it up. The idea is that it would save you from maintaining one less class that apparently has interface changes every so often:

+++ b/includes/saml_sp.Auth.inc
@@ -69,9 +45,17 @@ class saml_sp_Auth extends Auth {
+    if (variable_get('saml_sp__debug', FALSE)) {
+      watchdog('saml_sp', 'samlp:AuthnRequest =><br/><pre>@request</pre>', array('@request' => $this->getLastRequestXML()), WATCHDOG_DEBUG);
+      if (function_exists('dpm')) {
+        dpm($this->getXML(), 'samlp:AuthnRequest');
+      }
+    }

+++ /dev/null
@@ -1,22 +0,0 @@
-    if (variable_get('saml_sp__debug', FALSE)) {
-      watchdog('saml_sp', 'samlp:AuthnRequest =><br/><pre>@request</pre>', array('@request' => $this->getXML()), WATCHDOG_DEBUG);
-      if (function_exists('dpm')) {
-        dpm($this->getXML(), 'samlp:AuthnRequest');
-      }
-    }

Thoughts? @jrglasgow And could 3.x get a dev branch?

Thanks @jrglasgow!