Problem/Motivation

As title.

Proposed resolution

core/modules/path_alias/tests/src/Unit/AliasManagerTest.php

found
public function testGetPathByAliasNatch() {

expected
public function testGetPathByAliasMatch() {

Note Natch -> Match.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3155765-2.patch592 bytesnaresh_bavaskar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naresh_bavaskar created an issue. See original summary.

naresh_bavaskar’s picture

naresh_bavaskar
Location Pune, Maharashtra
CreditAttribution: naresh_bavaskar as a volunteer and at QED42 for Drupal India Association commented
Assigned: naresh_bavaskar » Unassigned
Status: Active » Needs review
FileSize
3155765-2.patch592 bytes
mayurjadhav’s picture

mayurjadhav CreditAttribution: mayurjadhav at Srijan | A Material+ Company commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Novice

Patch Looks Good to me, Moving this ticket to RTBC

TR’s picture

TR CreditAttribution: TR commented
Issue summary: View changes

This issue exists in D8 as well, and the commit can and should be cherry-picked back to 8.8, 8.9, and 9.0.

I triggered a test of #2 in older versions of core, and the patch still apples.

  • catch committed 4c8827c on 9.1.x 
    Issue #3155765 by naresh_bavaskar: Fixing minor typo in path alias...

  • catch committed dec18fa on 9.0.x 
    Issue #3155765 by naresh_bavaskar: Fixing minor typo in path alias...

  • catch committed 52e82da on 8.9.x 
    Issue #3155765 by naresh_bavaskar: Fixing minor typo in path alias...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Version: 9.1.x-dev » 8.9.x-dev
Status: Reviewed & tested by the community » Fixed

Had to read the patch three times to figure out where the typo was, but agreed - committed/pushed to 9.1.x and cherry-picked back to 8.9.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.