Closed (fixed)
Project:
Role Watchdog
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Jun 2020 at 13:59 UTC
Updated:
8 Jul 2020 at 14:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
markus_petrux commentedMmm... in fact, not sure if it makes sense to have permissions to view published/unpublished role watchdog entities or edit/delete them because these are managed automatically. Maybe only the "administer role watchdog entities" permission would be enough to control access to all the CRUD tasks on these entities?
Comment #3
gaurav.kapoor commented@markus_petrux I am not able to understand any use case of having "administer role watchdog entities" permission as everything related entity is managed programmatically.
Also, I believe there are a lot of other redundant classes which we do not need.
Comment #4
markus_petrux commentedAgree
It seems these entities are just use as a storage mechanism of the role changes activity. It makes little sense a permission to control access to view, create or edit these entities. But a mechanism to delete entries maybe?
The issue has been reported basically because the module does not defined permissions that it declares in the entity class definition of tries to use in the entity access handler, which makes the permission schema incomplete, at least.
Comment #5
gaurav.kapoor commented@markus_petrux,
For deleting, I am already working on deleting the entries in case the user account has been deleted. Do you think we should also get rid of the following files:
1. RoleWatchdogDeleteForm.php
2. RoleWatchdogForm.php
3. RoleWatchdogAccessControlHandler.php
4. RoleWatchdogHtmlRouteProvider.php
5. RoleWatchdogListBuilder.php
6. RoleWatchdogTranslationHandler.php
Do you see any use case of keeping these files or any feature using these files?
Comment #6
markus_petrux commentedI do not see the need to view, edit or create RoleWatchdog entities, but deleting might be needed, maybe in case a role change operation has been done by error and it is needed undo the change and remove the history?
Thank you!
Comment #7
gaurav.kapoor commentedI have added a view that can be used by administrators to view all the role watchdog entities as well as delete the history if needed.
Comment #8
gaurav.kapoor commentedComment #10
gaurav.kapoor commentedI have pushed it, for now, please create a new issue in case you find any bugs.