Problem/Motivation

Sub modules need to also specify the core_version_requirement so that Drupal's TestBot can resolve dependencies.

@see https://www.drupal.org/pift-ci-job/1729466

Proposed resolution

Add core_version_requirement to sub modules and tag a new release.

Remaining tasks

  • Write patch
  • Commit path
  • New release

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

CommentFileSizeAuthor
#2 clientside_validation_3153179-2.patch1.18 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new clientside_validation_3153179-2.patch1.18 KB

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Needs review » Fixed

Thanks for reporting the issue and providing the patch :)

jrockowitz’s picture

jrockowitz commented

@nikunjkotecha Thanks for committing the patch so fast.

If you want to be my hero and when you have time. I think if tag a new release all the Webform module's automated tests will suddenly start running in Drupal 9.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented

Done :)

Found one issue though, will try to fix tonight - https://www.drupal.org/pift-ci-job/1731451

Not sure if it will impact automated tests of webform but if it does, you can expect a fix soon.

nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented

https://www.drupal.org/project/clientside_validation/releases/3.0.0-rc4 onwards tests should pass

jrockowitz’s picture

jrockowitz commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.