CommentFileSizeAuthor
#2 3146462-2.patch320 byteskarishmaamin

Issue fork homebox-3146462

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

karishmaamin created an issue. See original summary.

karishmaamin’s picture

StatusFileSize
new320 bytes
karishmaamin’s picture

Status: Active » Needs review
bramdriesen’s picture

Status: Needs review » Reviewed & tested by the community

Would be nice to see this on the dev release.

bramdriesen’s picture

Note that this would only make the module installable. At the current stage it's not working at all. I created a follow up issue here #3204838: Fix entity definitions & deprecations for D9 to fix most of the issues I could spot while trying out the module.

damienmckenna’s picture

Title: Drupal 9 compatibility » Drupal 9 compatibility for Homebox
Status: Reviewed & tested by the community » Needs work
damienmckenna’s picture

Status: Needs work » Needs review

I updated the dependencies so that the separate jQuery UI modules can be loaded too.

damienmckenna’s picture

It seems like the problem with the draggable system not working is that the SortableJS library doesn't work with the data structure that Homebox provides.

In every example of SortableJS I can find, it expects the "draggable" items to be direct child of the main element. Homebox nests the draggable items several layers deep, so it can't find the items. I've gotten it to mostly work by disabling the "draggable" setting, so that it automatically just uses the DIVs inside the columns.

The full solution would be to fix the HTML output.

What works:

  • Reordering items inside a column.
  • Updating the display and having it reload with the changes in place.

What doesn't work:

  • Moving items from one column to another.
damienmckenna’s picture

Status: Needs review » Needs work

Just to clarify: The last part left is to work out how to make items draggable between columns.

anybody’s picture

@DamienMcKenna: Great work so far! Wouldn't you perhaps want to apply as Co-Maintainer of this project? Or is there a Maintainer for the Drupal 8/9 branch available to review and commit your changes?
See #3236974: Offering to maintain Homebox

The current Drupal 8 branch is old and broken... things can only become better...

@Maintainers: Could the current state of the @DamienMcKenna's work in the issue fork please be committed or at least be created as 2.x branch? Due to missing Drupal 9 compatibility in the .info.yml file, the current version can't even be tested in Drupal 9. Thanks!

anybody’s picture

Just to clarify: The last part left is to work out how to make items draggable between columns.

Just had a look at Layout Builder. It uses
https://github.com/SortableJS/Sortable

Perhaps that's the better choice here?

damienmckenna’s picture

@Anybody: I only used the system for one project and I don't work on it very much, so I'd prefer to not take on that burden.

anybody’s picture

anybody’s picture

Version: 8.x-1.x-dev » 2.0.x-dev

anybody’s picture

Status: Needs work » Fixed

Created a new semver release: 2.0.x for future Druapl 9 development. Let's continue in separate issues for open tasks. If required I'll create a meta issue.

anybody’s picture

@DamienMcKenna: FYI: I was able to fix the drag & drop issue: #3247103: Items not draggable between columns :) Thank you for your important hints!
I was also able to remove the jQuery drag / drop libraries.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.