I've noticed a few small bits of incorrect sentence casing. For reference, the User Interface Standards say: Page titles, links (in menus, too), and headings in Drupal should generally use sentence case capitalization, where only the first word is capitalized, except for proper nouns and other words that are generally capitalized by a more specific rule. Examples of sentence case capitalization include the following: "Block administration", "List menus", "Install new theme".
Most of Commerce does sentence casing just fine; these are just some small outliers I noticed. 1) On checkout/#/order_information, "Order information" is correct but "Order *S*ummary" needs improvement. 2) A few Views titles have casing that can be improved.
Screenshots attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | sentence_case-3145772-4.patch | 7.06 KB | morbus iff |
| #2 | sentence_case-3145772-2.patch | 5.76 KB | morbus iff |
| checkout.png | 57.8 KB | morbus iff | |
| views.png | 77.23 KB | morbus iff |
Comments
Comment #2
morbus iffComment #3
morbus iffComment #4
morbus iffPatch updated for Commerce 2.24.
Comment #5
rszrama commentedEasy +1 from me, just curious to know if we should worry about breaking translations or just go for it / provide a change record. Any idea on the process in other projects?
Comment #6
morbus iffIf a translator translated the strings without noticing they were wrong, that's on them ;)
I say break 'em. Dunno the process on other projects, though :(
Comment #7
morbus iffBump.
Comment #8
bojanz commented+1 from me.
Comment #11
jsacksick commentedCommitted! Thanks!