Using the PHP module for Drupal sites is a security and performance risk, therefore it shouldn't be encouraged by other modules.

Step 1:
Mark the PHP snippet as deprecated in Drupal 8 for both the 2.x and 3.x versions
Remove the tests around PHP so they pass in Drupal 9.

Step 2:
Write a plugin or generate an event that easily allows users to manipulate how GA is shown on pages

We can track the progress of both steps in this issue, with step 1 getting committed with the D9 release and step 2 being done later.

CommentFileSizeAuthor
#13 3145431-13.patch17.63 KBjaperry
#12 3145431-10.patch12.55 KBjaperry
#10 3145431-8.patch9.68 KBjaperry
#6 3145431-6.patch8.14 KBjaperry
#4 3145431-3.patch7.62 KBjaperry
#2 3145431-2.patch7.48 KBjaperry
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

japerry created an issue. See original summary.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Active » Needs review
FileSize
3145431-2.patch7.48 KB

This patch works for both branches.

Status: Needs review » Needs work

The last submitted patch, 2: 3145431-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Needs review
FileSize
3145431-3.patch7.62 KB

Status: Needs review » Needs work

The last submitted patch, 4: 3145431-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Needs review
FileSize
3145431-6.patch8.14 KB
fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented

Agreed on the issue. It's hardly critical, though: no site breaks for that reason, do they ?

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented

Its breaking tests, so it'd be nice if we didn't release with broken tests.

Status: Needs review » Needs work

The last submitted patch, 6: 3145431-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Title: Remove support for PHP module » Fix D9 broken tests and Remove support for PHP module
Status: Needs work » Needs review
FileSize
3145431-8.patch9.68 KB

Status: Needs review » Needs work

The last submitted patch, 10: 3145431-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Needs review
FileSize
3145431-10.patch12.55 KB
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
FileSize
3145431-13.patch17.63 KB

See if it works in 3.x

Status: Needs review » Needs work

The last submitted patch, 13: 3145431-13.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • japerry committed d1b36c5 on 8.x-2.x 
    Issue #3145431 by japerry: Remove PHP Filter test and deprecate use of...

  • japerry committed ff3dfc5 on 8.x-3.x 
    Issue #3145431 by japerry: Remove PHP Filter test and deprecate use of...
japerry’s picture

japerry
Location KVUO
CreditAttribution: japerry at Acquia commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.