Currently, after the OpenID login user gets redirected to the same URL but the user's site language doesn't persist if it's other than the site's default language.

CommentFileSizeAuthor
#22 openid_connect-langauge-support-destination-redirect-3143650-22.patch5.69 KBBeNjY44
#18 openid_connect-language-support-destination-redirect-3143650-18.patch14.39 KBjcnventura
#14 openid_connect-langauge-support-destination-redirect-2953289-3143650-14.patch6.01 KBsonu.raj.chauhan
#11 interdiff-6-8.txt1.82 KBSharique
#9 openid_connect-langauge-support-destination-redirect-3143650-8.patch6.01 KBSharique
#8 openid_connect-langauge-support-destination-redirect-3143650-8.patch.txt6.01 KBSharique
#6 openid_connect-langauge-support-destination-redirect-3143650-6.patch6 KBsonu.raj.chauhan
#5 openid_connect-langauge-support-destination-redirect-3143650-5.patch5.61 KBsonu.raj.chauhan
#2 openid_connect-langauge-support-destination-redirect-3143650-2.patch5.67 KBsonu.raj.chauhan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sonu.raj.chauhan created an issue. See original summary.

sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
FileSize
openid_connect-langauge-support-destination-redirect-3143650-2.patch5.67 KB
sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
Status: Active » Needs review
sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
Assigned: sonu.raj.chauhan » Unassigned
sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
FileSize
openid_connect-langauge-support-destination-redirect-3143650-5.patch5.61 KB
sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
FileSize
openid_connect-langauge-support-destination-redirect-3143650-6.patch6 KB

Status: Needs review » Needs work

The last submitted patch, 6: openid_connect-langauge-support-destination-redirect-3143650-6.patch, failed testing. View results

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer and at Acquia commented
FileSize
openid_connect-langauge-support-destination-redirect-3143650-8.patch.txt6.01 KB

Re-rolled patch to be based on latesed dev.

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer and at Acquia commented
FileSize
openid_connect-langauge-support-destination-redirect-3143650-8.patch6.01 KB

Updating patch extension,.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented

Interdiffs, please!

Sharique’s picture

Sharique CreditAttribution: Sharique as a volunteer and at Acquia commented
FileSize
interdiff-6-8.txt1.82 KB

Inter dif added.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: openid_connect-langauge-support-destination-redirect-3143650-8.patch, failed testing. View results

sonu.raj.chauhan’s picture

sonu.raj.chauhan CreditAttribution: sonu.raj.chauhan as a volunteer and for Publicis Sapient commented
FileSize
openid_connect-langauge-support-destination-redirect-2953289-3143650-14.patch6.01 KB

Adding rerolled patch to make it compatible with https://www.drupal.org/project/openid_connect/issues/2953289 issue patch.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Version: 8.x-1.x-dev » 2.x-dev

Needs a re-roll for version 2.x of the module, as 1.x is no longer getting new features.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Postponed
Related issues: +#3022086: Support for destination query parameter

We need to address #3022086: Support for destination query parameter before we can try to come back to this one.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Postponed » Needs work

Back to needs work because of the re-roll. Also, there is now a 'redirect_login' parameter that should also be tested for the language redirect.

jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs work » Needs review
FileSize
openid_connect-language-support-destination-redirect-3143650-18.patch14.39 KB

It was considerably more than a re-roll, but sadly no interdiff as the original patch doesn't apply anymore.

  • jcnventura authored 7fdcb9f on 2.x 
    Issue #3143650 by sonu.raj.chauhan, Sharique, jcnventura: Support...
jcnventura’s picture

jcnventura CreditAttribution: jcnventura at 1xINTERNET commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

BeNjY44’s picture

BeNjY44
Primary language French
CreditAttribution: BeNjY44 commented
Version: 2.x-dev » 8.x-1.1
FileSize
openid_connect-langauge-support-destination-redirect-3143650-22.patch5.69 KB

Add patch for 8.x-1.1