CommentFileSizeAuthor
#7 interdiff_3143511_3-7.txt3.56 KBankithashetty
#7 3143511-7.patch2.96 KBankithashetty
#3 ffd_3143511_1.patch2.38 KBkavitasonawane

Comments

kavitasonawane created an issue. See original summary.

kavitasonawane’s picture

kavitasonawane commented
Title: $this->t() should be used instead of t() for Drupal 8 version » $this->t() should be used instead of t()
kavitasonawane’s picture

kavitasonawane commented
StatusFileSize
new ffd_3143511_1.patch2.38 KB
kavitasonawane’s picture

kavitasonawane commented
Status: Active » Needs review
sahana _n’s picture

sahana _n commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly moving to RTBC.

labboy0276’s picture

labboy0276 commented
Status: Reviewed & tested by the community » Needs work

Causes fatal errors due to $this->t in the .module

Please address this and test the module.

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Status: Needs work » Needs review
StatusFileSize
new 3143511-7.patch2.96 KB
new interdiff_3143511_3-7.txt3.56 KB

Updated the patch in #3 to avoid t() calls wherever necessary. Removed the $this->t() calls in fancy_file_delete.module and src/Entity/UnmanagedFiles.php file as it throws an error => Cannot use '$this' in non-object context. Kindly review.

Thank you!

labboy0276’s picture

labboy0276 commented
Status: Needs review » Fixed

Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.