Status report wrongly warns of APCu memory limit when admin language is not English

As no way to factor/mock this setting

Needs steps to test

I still have this problem after applying the patch. on status report page `/admin/reports/status`
... Drupal can run with a 32 МБ APCu limit. However, a 32 MB APCu limit (the default) or above ...

* 33554312 = [$memory_info['seg_size'] (default php7.+ = value 32M)
* 33554432 = Bytes::toInt($apcu_recommended_size)
We need to add another `120 bytes` somewhere.

if ($memory_info['seg_size'] + 120 < Bytes::toInt($apcu_recommended_size)) {

it fixes the problem, but maybe the real reasons maybe should be found in `Bytes::toInt()`?

The problem is still not resolved
Drupal 9.0.7

@Chi, I tried it now - patch really works

$ composer update drupal/system
Gathering patches for root package.
Removing package drupal/core so that it can be re-installed and re-patched.
- Removing drupal/core (9.0.7)
Deleting web/core - deleted
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing drupal/core (9.0.7): Loading from cache
- Applying patches for drupal/core
https://www.drupal.org/files/issues/2020-05-26/apcu-memory-report-314292... (Status report wrongly warns of APCu memory limit when admin language is not English)

$ grep apcu_recommended core/modules/system/system.install
$apcu_recommended_size = '32 MB';
if ($memory_info['seg_size'] < Bytes::toInt($apcu_recommended_size)) {
'@apcu_default_size' => $apcu_recommended_size,

Drupal 9.1.0 - patch doesn't work

$ composer update drupal/system
Gathering patches for root package.
Removing package drupal/core so that it can be re-installed and re-patched.
- Removing drupal/core (9.1.0)
Deleting web/core - deleted
Loading composer repositories with package information
Package "drupal/system" listed for update is not locked.
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
- Installing drupal/core (9.1.0): Extracting archive
- Applying patches for drupal/core
https://www.drupal.org/files/issues/2020-05-26/apcu-memory-report-314292... (Status report wrongly warns of APCu memory limit when admin language is not English)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2020-05-26/apcu-memory-report-314292...

Package container-interop/container-interop is abandoned, you should avoid using it. Use psr/container instead.
Package doctrine/reflection is abandoned, you should avoid using it. Use roave/better-reflection instead.
Generating autoload files
42 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
Scaffolding files for drupal/core:

[RuntimeException]
Could not delete /var/www/html/web/sites/default/default.services.yml:

update [--with WITH] [--prefer-source] [--prefer-dist] [--dry-run] [--dev] [--no-dev] [--lock] [--no-install] [--no-autoloader] [--no-scripts] [--no-suggest] [--no-progress] [-w|--with-dependencies] [-W|--with-all-dependencies] [-v|vv|vvv|--verbose] [-o|--optimize-autoloader] [-a|--classmap-authoritative] [--apcu-autoloader] [--apcu-autoloader-prefix APCU-AUTOLOADER-PREFIX] [--ignore-platform-req IGNORE-PLATFORM-REQ] [--ignore-platform-reqs] [--prefer-stable] [--prefer-lowest] [-i|--interactive] [--root-reqs] [--] [
]...

conflict was with #3142934: Replace \Drupal\Component\Utility\Bytes::toInt() with \Drupal\Component\Utility\Bytes::toNumber() due to return type which just changed the name of the bytes helper method. Resolving the conflict should be trivial.

Concept looks correct though, don't rely on parsing the translated bytes value.

Updated patch file included for use with composer.

MR: https://git.drupalcode.org/project/drupal/-/merge_requests/670

It should be fixed in 9.3 first

Hi everyone
Here is to report that the issue was detected with Drupal version 9.3.0. Here is the error:

Depending on your configuration, Drupal can run with a 32 MB APCu limit. However, a 32 MB APCu limit (the default) or above is recommended, especially if your site uses additional custom or contributed modules.

Seems that there is a localization issue since the error is not displayed in the default language. Thanks to the idea provided in #7 the issue was resolved. Hope the core development teams look into this issue and fix it at the core level.

I have tried to reproduce this issue locally using 9.3.x, 9.4.x, and 9.5.x. For all the versions it's working as expected, i.e. when the apc.shm_size is less than 32MB it's showing the warnings and when it's greater than 32MB, there are no such warnings!
NOTE: I have tried using MAMP (apache+mysql) and tried Spanish and French Languages along with/without English.

Attaching the screenshot for 64MB and 14M messages and warning.

I solved my problem with this code:

core/modules/system/system.install

395 - $apcu_actual_size = format_size($memory_info['seg_size']);
395 + $apcu_actual_size = format_size($memory_info['seg_size'],'en');

Who can please make these changes in Drupal.

@wiktor7

Attached is a patch with the changes you suggested

The correct fix is already in the merge request. That change breaks localization.

Patch from MR works (Drupal 9.4) but string number is incorrect for Drupal 9.4. Needs reroll?

This will need tests to show the test.

Also was previously tagged for IS update.

Did not test the issue.

Missed that.

Drupal 9.5.10

Drupal 10.2.0

To see this issue on a multilingual site, the string @size MB must be localized.

My solution fixes the issue while respecting the user language, however, I think the best solution is to make the byte comparison work correctly when comparing two byte representations in two different languages, or to just compare the byte size as numbers, not as strings.

@alayham Yeah, the suggestion all along has been to avoid any localization and compare number/byte sizes directly.

https://git.drupalcode.org/project/drupal/-/merge_requests/670/diffs#not...

This was only in needs work because it doesn't have tests which is still true.

I have same problem as #7

$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');
doesn't help

if ($memory_info['seg_size'] < Bytes::toNumber($apcu_recommended_size))
doesn't help too

hi.
this patch work for me in drupal 10.2.7:
status-report-apcu-3142928.patch

go to /core/modules/system/
then edit system.install
in line 427 remove
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size']);
replace with
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');

Per #5 this isn't going to be testable in a useful way - we can't fake the apcu memory limit for system_requirements(). Also think this is a good example where the new policy on https://www.drupal.org/about/core/policies/core-change-policies/core-gat... should apply.

Can the issue summary be updated with least proposed solution and before/after screenshots.

Also the 1 MR still visible is for 9.1.x and still a number of patches so not sure which is to be reviewed.

Can the issue summary be updated to include steps to reproduce the problem and ultimately what the proposed solution is.

btw that after screenshot is that the wrong item?

One comment on the MR.

btw that after screenshot is that the wrong item?

smustgrave, after screenshot doesn't have wrong warning about cache size

Latest change in the MR looks good, but probably needs one more round of manual testing?

I have the same problem. MR works for me

Committed and pushed 37d8ea5cb4 to 11.x and e1902fee88 to 11.0.x and eeca1aec09 to 10.4.x and 2664526bdb to 10.3.x. Thanks!

Thanks you a lot!

Oh wow, this is an old one. Thanks!

Just for info:
If php.ini: apc.shm_size=32M

https://github.com/krakjoe/apcu/blob/v5.1.23/apc_sma.c#L565

info->seg_size = sma->size - (ALIGNWORD(sizeof(sma_header_t)) + ALIGNWORD(sizeof(block_t)) + ALIGNWORD(sizeof(block_t)));

seg_size = = 33554312b, not 33554432b (32M) - 120 bytes difference in my server.
so $apcu_recommended_size = '32 MB'; in system.install isn't exact value for comparing.

@Nikit nice details, thank you!

this requires a follow-up, as now there is a warning with comparing 32 Mb to 32 MB (and the reason is described by @Nikit )

PHP APCu caching
Enabled (32 MB)
Depending on your configuration, Drupal can run with a 32 MB APCu limit. However, a 32 MB APCu limit (the default) or above is recommended, especially if your site uses additional custom or contributed modules.

The follow-up is here: #3466399: APCu requirement for 32M is checking wrong value