Added core_version_requirement: ^8 || ^9 to info.yml file.

CommentFileSizeAuthor
#8 upgrade-status.png10.29 KBmatija5
#3 interdiff_2-3.txt348 bytesmatija5
#3 3142550-3.patch730 bytesmatija5
#2 3142550-2.patch382 bytesmatija5

Comments

vebrovski created an issue. See original summary.

matija5’s picture

matija5 commented
Assigned: matija5 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3142550-2.patch382 bytes

6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] Rector is done!

matija5’s picture

matija5 commented
StatusFileSize
new 3142550-3.patch730 bytes
new interdiff_2-3.txt348 bytes

Also added core requirement in composer.json.

matija5’s picture

matija5 commented

Based on D9 compatibility you don't need to add requirement in composer.json file so you can ignore #3 patch.

chi’s picture

chi commented
Status: Needs review » Reviewed & tested by the community

Having composer.json makes sense anyway.

mrpauldriver’s picture

mrpauldriver commented
Status: Reviewed & tested by the community » Needs work

I am seeing two remaining errors when tested with Upgrade status module.

CUSTOM PROJECTS
--------------------------------------------------------------------------------
Media Library Edit
Scanned on Sat, 06/06/2020 - 10:00.

2 warnings found.

web/modules/contrib/media_library_edit/tests/src/Functional/LoadTest.php:
┌──────────┬──────┬─────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                           │
├──────────┼──────┼─────────────────────────────────────────────────────────────┤
│ Check    │      │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
│ Check    │ 13   │ Class PHPUnit\Framework\TestCase not found and could not be │
│ manually │      │ autoloaded.                                                 │
│          │      │                                                             │
└──────────┴──────┴─────────────────────────────────────────────────────────────┘
matija5’s picture

matija5 commented
Assigned: Unassigned » matija5
matija5’s picture

matija5 commented
Assigned: matija5 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new upgrade-status.png10.29 KB

Hi, thanks for review.

Do you have PHPUnit set up?

I don't have any issues in upgrade status (ss), drupal check or rector.

vendor/bin/drupal-check web/modules/contrib/media_library_edit
2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] No errors

vendor/bin/rector process web/modules/contrib/media_library_edit --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml

6/6 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

[OK] Rector is done!

Also running tests did not find any issue

Drupal test run
---------------

Tests to be run:
- Drupal\Tests\media_library_edit\Functional\LoadTest

Test run started:
Monday, June 8, 2020 - 04:48

Test summary
------------

Drupal\Tests\media_library_edit\Functional\LoadTest 1 passes

Test run duration: 30 sec

Detailed test results
---------------------

---- Drupal\Tests\media_library_edit\Functional\LoadTest ----

Status Group Filename Line Function
--------------------------------------------------------------------------------
Pass Other LoadTest.php 41 Drupal\Tests\media_library_edit\Fun

mrpauldriver’s picture

mrpauldriver commented
Status: Needs review » Reviewed & tested by the community

Actually I am not seeing this error today. Perhaps just a mistake.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.