Problem/Motivation

Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 9.

To read more about this effort by the Drupal Association, please read: Accelerating Drupal 9 module and theme readiness with automated patches

Periodically patches will be added to this issue that remove Drupal 9 deprecations. To stop further patches from being posted simply close this issue(any status besides Active, Needs Review or Needs work) or remove the "ProjectUpdateBotD9" tag from the issue.

The patches will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open(status of Active, Needs Review or Needs work) and the "RectorAutoPatches" tag is left on this issue, new patches will be posted periodically if new deprecations are needed.

    As the Drupal Rector project improves and is able to fix more deprecations the patches posted here will cover more of the deprecations in the module.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecations but don't want new automated patches simply leave this issue open but remove the "RectorAutoPatches" from the issue.

    You can use Drupal Rector yourself to make these patches.

    If you want to receive automated patches again simply add back the "RectorAutoPatches" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful they can simply close this issue(any status besides Active, Needs Review or Needs work) and no more automated patches will be posted here.

    If the issue is reopened then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 9 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the patch in the comment by Project Update Bot
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear,  use the Infrastructure project issue queue using the component “Bot: Drupal Rector”.

CommentFileSizeAuthor
#2 label_help.1.x-dev.rector.patch375 bytesproject update bot

Issue fork label_help-3140898

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Project Update Bot created an issue. See original summary.

project update bot’s picture

project update bot commented
Status: Active » Needs review
StatusFileSize
new label_help.1.x-dev.rector.patch375 bytes
Patch for Build #1473

This is an automated patch generated by Drupal Rector. Please see the issue summary for more details.

It is important that any automated tests available are run with this patch and that you manually test this patch.

This patch was created using these packages:

  1. mglaman/phpstan-drupal: 0.12.3
  2. palantirnet/drupal-rector: 0.5.4
  3. rector/rector-prefixed: dev-master

Debug info: Run #1473

project update bot’s picture

project update bot commented
Issue summary: View changes
Issue tags: +Drupal 9 compatibility

Fixing summary

Liam Morland made their first commit to this issue’s fork.

Liam Morland opened merge request !1

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Issue summary: View changes

At Bluespark we've created a clone of the project at https://github.com/meladawy/drupal-label_help in order to create a 2.x branch that fixes the Drupal 9 compatibility issues.

We're currently using it like this in our Composer.json:

    "repositories": {
        "drupal/label_help": {
            "type": "package",
            "package": {
                "name": "drupal/label_help",
                "version": "2.x-dev",
                "type": "drupal-module",
                "source": {
                    "url": "https://github.com/meladawy/drupal-label_help",
                    "type": "git",
                    "reference": "8.x-2.x"
                }
            }
        }
    }

I've reached out on the maintainer issue #3237326: Offering to maintain Label Help to request maintainership and thereby get fixes for this issue as well as my other issue #2948501: Improve Drupal 8 field compatibility integrated.

jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Related issues: +#3237326: Offering to maintain Label Help, +#2948501: Improve Drupal 8 field compatibility

  • Liam Morland committed 5383c27 on 8.x-1.x 
    Issue #3140898: Use core_version_requirement key in info file
jwilson3’s picture

jwilson3
Primary language English
Location Ecuador
commented
Status: Needs review » Fixed

This has been fixed on the 8.x-1.x branch, I've also released version 8.x-1.0 containing the drupal 8 port from gnuget, several fatal error fixes from the original author/maintainer, plus the Drupal 9 compatibility fix from this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This ticket could be left open to receive more automated patches if desired; see #1 in the issue summary.