Drupal 9 compatibility report by Upgrade Status module

Smart Entity Reference Selection, --
Scanned on Thu, 05/21/2020 - 09:37

FILE: modules/d9/sers/src/Plugin/EntityReferenceSelection/SmartSelection.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix now        46   Parameter $entity_manager of method                         
                    Drupal\sers\Plugin\EntityReferenceSelection\SmartSelection::
                    __construct() has typehint with deprecated interface        
                    Drupal\Core\Entity\EntityManagerInterface. Deprecated in    
                    drupal:8.0.0 and is removed from drupal:9.0.0.              
--------------------------------------------------------------------------------

FILE: modules/d9/sers/sers.info.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    Add <code>core_version_requirement: ^8 || ^9

to
sers.info.yml to designate that the module is compatible
with Drupal 9. See https://drupal.org/node/3070687.
--------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 sers-d9-compatibility.patch2.17 KBsutharsan

Issue fork sers-3138483

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Sutharsan created an issue. See original summary.

sutharsan’s picture

sutharsan commented
Status: Active » Needs review
StatusFileSize
new sers-d9-compatibility.patch2.17 KB

The patch changes the DefaultSelection constructor, but the parent constructor (\Drupal\Core\Entity\Plugin\EntityReferenceSelection\DefaultSelection::__construct) already uses entityTypeManagerInterface. Therefore this change should be without problems.

scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented

I agree, the patch makes sense.

Currently I don't have a project setup to test this, or have the time to set this up. Just wanted to add that it looks to me, that this is good to go.
If someone can test this patch on a working project. I'm happy to commit it.

sutharsan’s picture

sutharsan commented
Status: Needs review » Reviewed & tested by the community

I've tested the patch during upgrade of a site. It works correctly.

RTBC-ing, despite that I am the patch author.

scuba_fly opened merge request !1

  • scuba_fly committed 0264063 on 8.x-1.x authored by Sutharsan 
    Issue #3138483 by Sutharsan, scuba_fly: Drupal 9 compatibility
  • scuba_fly committed a42c60f on 8.x-1.x
    Issue #3138483 by scuba_fly fix coding standards
scuba_fly’s picture

scuba_fly
Location Netherlands, Vinkeveen
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.