While running the tests in Drupal 9 there is a warning:

1x: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of geshifield_formatter_default(). See https://www.drupal.org/node/1831138
1x in GeshiFieldTest::testAddField from Drupal\Tests\geshifield\Functional

CommentFileSizeAuthor
#2 theme_function_deprecated--3137937-2.patch2.26 KBdom.

Comments

yukare created an issue. See original summary.

dom.’s picture

dom. commented
Status: Active » Needs review
StatusFileSize
new theme_function_deprecated--3137937-2.patch2.26 KB

Adding a patch here to do so.
This is a "fastly done patch", meaning it's main purpose is to fix functionally the issue and avoid the deprecation notice on cache clear.

However, from a technical point of view, I wonder if GeshiFilterProcess::geshiProcess() should be changed to template rather than the geshifield. What triggers me is the code added at the end of this method. This code can't be customized because not in a twig.

Anyway, adding the patch if it can help someone.

liber_t’s picture

liber_t
she/her
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

Working for me

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

Can also confirm that #2 works for me on core 9.2.6.

solimanharkas’s picture

solimanharkas commented

I can confirm that #2 works for me on core 9.3.3

  • yukare committed 01399790 on 3.0.x authored by Dom. 
    Issue #3137937 by Dom.: Theme functions are deprecated in geshifield
yukare’s picture

yukare commented

Commited the patch to 3.0.x, with this geshifield works on Drupal 10, thanks.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Version: 8.x-2.x-dev » 3.0.x-dev
Status: Reviewed & tested by the community » Fixed

Just marking as fixed for you. ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.