and optionally, and flag Drupal 9 support.

CommentFileSizeAuthor
#5 interdiff.txt185 bytessahana _n
#5 Add-core_version_requirement-to-info.yml-3137475-5.patch635 bytessahana _n
#2 Add-core_version_requirement-to-info.yml-3137475-2.patch586 bytessahana _n

Comments

mxr576 created an issue. See original summary.

sahana _n’s picture

sahana _n commented
Status: Active » Needs review
StatusFileSize
new Add-core_version_requirement-to-info.yml-3137475-2.patch586 bytes

Please review the patch.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented

"core" key should be removed.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work
sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new Add-core_version_requirement-to-info.yml-3137475-5.patch635 bytes
new interdiff.txt185 bytes

Please review the patch.

mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented

Did not spot it yesterday, this key is only available and respected since Drupal 8.7.7 if I am not mistaken. This should be reflected in the required versions. https://www.drupal.org/node/3070687

tobybellwood’s picture

tobybellwood commented

My inclination here would be to include both the core and core_version_requirement lines, given that there is no deprecated code indicated in the module. This will simplify releases going forward. We can always semver a new branch if we need to accommodate a non-b/c update.

core: 8.x
core_version_requirement: ^8 || ^9

And again, given the generic applicability of the module, I'd also drop the superfluous entry in require as per https://www.drupal.org/project/project_composer/issues/3084063

tobybellwood’s picture

tobybellwood commented
Status: Needs review » Needs work
mxr576’s picture

mxr576
Primary language Hungarian
Location Hungary
commented

My inclination here would be to include both the core and core_version_requirement lines, given that there is no deprecated code indicated in the module. This will simplify releases going forward.

I get your point and you are also right, I'm usually working on more complex modules that this one, and there is always question if we would like to support Drupal core versions that are not supported. We usually do not. Drupal 8.7.x is close to EOL and with that the old "core" key becomes also forgotten. This is the reason why I have suggested the above. Of course, dropping <= 8.7 support could happen in a new 2.x branch.

  • Sahana _N authored dcb7eec on 8.x-1.x 
    Issue #3137475 by Sahana _N: Add core_version_requirement to info.yml
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs work » Fixed

this is fixed in HEAD

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.