Cannot use Rules module in D9

Here's an idea, to not require-dev "drupal/rules": "^3" and skip the tests if running at D9.
Not sure this will work at D8, but worth trying.

The D9 composer failure is because it is being loaded before the patch has chance to take effect. To get round this we'll have to commit the change to remove drupal/rules, the could use a patch in drupalci.yml to add it back in if not running D9. It would mean that local testing using the compoer.json file would not get the Rules module, but chances are the local environment would already have Rules, or the developer would know and manually add it.

It's worth a try, can always back out if it's a poor idea.

Before, in the D9 branch test we had

--- Commands Executed ---
sudo -u www-data /usr/local/bin/composer  require --no-interaction 'drupal/coder:^8.3.3' 'drupal/devel_generate:^2.0' 'drupal/rules:^3' 'drush/drush:^9.0' --prefer-stable --no-progress --no-suggest --working-dir /var/www/html
Return Code: 2

With this commit we have

--- Commands Executed ---
sudo -u www-data /usr/local/bin/composer  require --no-interaction 'drupal/coder:^8.3.3' 'drupal/devel_generate:^2.0' 'drupal/rules:*' 'drush/drush:^9.0' --prefer-stable --no-progress --no-suggest --working-dir /var/www/html
Return Code: 2

Rules is still being required, but now drupal/rules:* instead of drupal/rules:^3

Is this due to the scheduler_rules_integration module, which has "drupal/rules": "^3.x" or maybe it is because scheduler.info.yml has

 test_dependencies:
  - devel:devel_generate
  - rules:rules

We had the same branch composer failure. Now after removing from sub-module too, we get a failure on devel_generate. The 2.x branch is not D9 compatible, but the latest 3.x-dev is.

Allow devel_generate 2.0 or 3.x-dev, and allow drush 9.0 or 10.0

That's better. The composer conflicts are sorted and D9 tests now actually start, and so do the D8 tests. Need to skip the Rules test classes as in the commit above.

For the future, here is a patch which restores the Rules requirements and testing. This can be used when Rules has a D9-compatible version, or when there is an alternative way to use Rules in D8 but not in D9.

Stale form data.

Here's a single patch to remove the Rules requirements, to allow testing at D9

Cannot test this patch at D9, but it is exactly the same as the multiple commits done previously on this thread, so it will run OK on D9 when committed. This will allow the 'Test on commit' for D9 to run again.

This should remain as an active issue until Rules has a 9.x version we can use in our 9.x testing.

Updated summary to explain how to use Scheduler 8.x-1.3 with Drupal 9

Rules is now compatible at Core 9.x so we can restore the requirements and tests.

No that I have fixed the missed deprecations in the ActionsTest on #3097919-17: Deprecations: Replace non-boolean use of assertTrue() and assertFalse() we should get better results.