Problem/Motivation

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
Thunder Admin 8.x-3.3
Scanned on Wed, 05/13/2020 - 22:21.

2 warnings found.

web/themes/contrib/thunder_admin/thunder_admin.info.yml:

┌──────────┬──────┬────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                        MESSAGE                         │
├──────────┼──────┼────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^8 || ^9 to │
│ manually │      │ thunder_admin.info.yml to designate that the module is │
│          │      │ compatible with Drupal 9. See                          │
│          │      │ https://drupal.org/node/3070687.                       │
│          │      │                                                        │
└──────────┴──────┴────────────────────────────────────────────────────────┘

web/themes/contrib/thunder_admin/composer.json:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ The drupal/core requirement is not Drupal 9 compatible.    │
│ manually │      │ Either remove it or update it to be compatible with Drupal │
│          │      │ 9. See                                                     │
│          │      │ https://drupal.org/node/2514612#s-drupal-9-compatibility.  │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#8 interdiff-3136355-4-8.txt235 bytesmrinalini9
#8 3136355-8.patch744 bytesmrinalini9
#4 3136355-4.patch742 bytesoknate
#3 3136355-3.patch745 bytesoknate
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

oknate created an issue. See original summary.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Issue summary: View changes
oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
Status: Active » Needs review
FileSize
3136355-3.patch745 bytes

Here's a patch.

oknate’s picture

oknate
Location Greater New York City Area
CreditAttribution: oknate as a volunteer and commented
FileSize
3136355-4.patch742 bytes

fixing typo

Kristen Pol’s picture

Kristen Pol
she/her
Primary language English
Location Santa Cruz, CA, USA
CreditAttribution: Kristen Pol at Hook 42 commented
Issue tags: +Drupal 9 compatibility
szato’s picture

szato CreditAttribution: szato at Brainsum commented
Status: Needs review » Needs work

I think we should go from 8.8.x to 9.x. So proposed ^8.7 || ^9 seems strange for me.

szato’s picture

szato CreditAttribution: szato at Brainsum commented
Related issues: +#3142632: Make compatible with drupal 9
mrinalini9’s picture

mrinalini9 CreditAttribution: mrinalini9 at Srijan | A Material+ Company for Drupal India Association commented
Status: Needs work » Needs review
FileSize
3136355-8.patch744 bytes
interdiff-3136355-4-8.txt235 bytes

Updated patch as per the changes mentioned in #6, please review.

volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
Status: Needs review » Fixed

This was fixed in #3132768: Drupal core deprecated jquery ui sortable breaking sortableFractionalPixels and will be released with version 8.x-3.4
3.x versions will require ^8.8 and not be compatible with drupal 9, I will create a 4.0 release today.

volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
Status: Fixed » Needs work
volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
Title: Add core_version_requirement for Drupal 9 » Add core_version_requirement and remove composer requirement
volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented

core_version_requirement was added in #3132768: Drupal core deprecated jquery ui sortable breaking sortableFractionalPixels, release 8.x-3.4 will require drupal 8.8.

There will be a new 8.x-4.x branch supporting drupal 9, with a 8.x-4.0 release coming soon.

  • volkerk authored 20d5ad1 on 8.x-3.x, 8.x-4.x 
    Issue #3136355 by oknate, mrinalini9, volkerk, szato, Kristen Pol: Add...
volkerk’s picture

volkerk CreditAttribution: volkerk at Thunder commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.