Follow up issue to add tests.

Issue fork entity_visibility_preview-3135427

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Related issues: +#3143493: Make the "bypass EVP access checks" permission work with content lists
bakop’s picture

bakop
Primary language French
commented
Assigned: Unassigned » bakop

Hello,

I'm on it !

bastienkopka opened merge request !2

bakop’s picture

bakop
Primary language French
commented
Assigned: bakop » Unassigned
Status: Active » Needs review

It's done !

Can you check please ?

Thanks.

bakop’s picture

bakop
Primary language French
commented
Assigned: Unassigned » bakop
Status: Needs review » Active
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Active » Needs work

"Needs work" not "Active" when there is already a patch or a MR :)

bakop’s picture

bakop
Primary language French
commented
Status: Needs work » Needs review
bakop’s picture

bakop
Primary language French
commented
Status: Needs review » Needs work
bakop’s picture

bakop
Primary language French
commented
Assigned: bakop » Unassigned
Status: Needs work » Needs review

It's done !

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Ok, reviewing

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

Rebased and squashed MR.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Needs work

Nice work! :)

Needs some more cases to be checked, please see review comments.

bakop’s picture

bakop
Primary language French
commented
Status: Needs work » Needs review

Hello, i added a new method to test the preview mode and i fixed what you asked me.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Status: Needs review » Needs work

Thanks :)

Still some points. Also I rebased the MR and you repushed the commits...

bakop’s picture

bakop
Primary language French
commented
Assigned: Unassigned » bakop
bakop’s picture

bakop
Primary language French
commented
Assigned: bakop » Unassigned
Status: Needs work » Needs review
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Almost done.

I will make the last small adjustments.

  • Grimreaper committed 57631cc on 8.x-1.x authored by bastienkopka 
    Issue #3135427 by bastienkopka, Grimreaper: Tests: bypass access
  • Grimreaper committed ab27990 on 8.x-1.x
    Issue #3135427 by bastienkopka, Grimreaper: Tests: bypass access,...
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Needs review » Fixed

Merged!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.