Problem/Motivation

drupal-check output:

drupal-check web/modules/contrib/language_cookie 
 20/20 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------- 
  Line   src/EventSubscriber/LanguageCookieSubscriber.php                      
 ------ ---------------------------------------------------------------------- 
  166    Call to deprecated constant REQUEST_TIME: Deprecated in drupal:8.3.0  
         and is removed from drupal:9.0.0. Use                                 
         \Drupal::time()->getRequestTime();                                    
 ------ ---------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------- 
  Line   src/Plugin/LanguageCookieCondition/LanguageCookieConditionBlacklistedPaths.php  
 ------ -------------------------------------------------------------------------------- 
  73     Parameter $alias_manager of method                                              
         Drupal\language_cookie\Plugin\LanguageCookieCondition\LanguageCookieC           
         onditionBlacklistedPaths::__construct() has typehint with deprecated            
         interface Drupal\Core\Path\AliasManagerInterface:                               
         in drupal:8.8.0 and is removed from drupal:9.0.0.                               
         Use \Drupal\path_alias\AliasManagerInterface.                                   
  109    Call to deprecated method strtolower() of class                                 
         Drupal\Component\Utility\Unicode:                                               
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                           
         mb_strtolower() instead.                                                        
 ------ -------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/Plugin/LanguageCookieCondition/LanguageCookieConditionHardcodedBlacklistedPaths.php  
 ------ ----------------------------------------------------------------------------------------- 
  83     Parameter $alias_manager of method                                                       
         Drupal\language_cookie\Plugin\LanguageCookieCondition\LanguageCookieC                    
         onditionHardcodedBlacklistedPaths::__construct() has typehint with                       
         deprecated interface Drupal\Core\Path\AliasManagerInterface:                             
         in drupal:8.8.0 and is removed from drupal:9.0.0.                                        
         Use \Drupal\path_alias\AliasManagerInterface.                                            
  129    Call to deprecated method strtolower() of class                                          
         Drupal\Component\Utility\Unicode:                                                        
         in drupal:8.6.0 and is removed from drupal:9.0.0. Use                                    
         mb_strtolower() instead.                                                                 
 ------ ----------------------------------------------------------------------------------------- 

                                                                                
 [ERROR] Found 5 errors                                                         
                                                                               

Deprecations after running tests:


Remaining tasks

  • Fix deprecations listed above.
  • Add core_version_requirement to language_cookie.info.yml
CommentFileSizeAuthor
#8 3134366-8.patch9.38 KBjeroent
#6 3134366-6.patch9.35 KBjeroent
#3 3134366-3.patch4.79 KBsja112

Comments

JeroenT created an issue. See original summary.

sja112’s picture

Assigned: Unassigned » sja112
sja112’s picture

Status: Active » Needs review
StatusFileSize
new4.79 KB

I have created patch to fix,

1. Deprecations listed above.
2. To add core_version_requirement to language_cookie.info.yml

sja112’s picture

Assigned: sja112 » Unassigned
jeroent’s picture

Status: Needs review » Needs work
jeroent’s picture

Status: Needs work » Needs review
StatusFileSize
new9.35 KB
jeroent’s picture

The D9 branch is failiing because of #3124380: Drupal 9 Deprecated Code Report.

jeroent’s picture

StatusFileSize
new9.38 KB

Patch no longer applied. Creating reroll.

Status: Needs review » Needs work

The last submitted patch, 8: 3134366-8.patch, failed testing. View results

  • JeroenT committed 27b55f1 on 8.x-1.x
    Issue #3134366 by JeroenT, sja112: Drupal 9 Deprecated Code Report
    
jeroent’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.