PHPunit tests are failing in #3131836: Run PHPunit tests for the Guardr Profile in Guardr Project. Related next steps are in #3131836: Run PHPunit tests for the Guardr Profile in Guardr Project.

GuardrTest.php should match what is in the current Drupal core 9.0.x branch to allow PHPUnit tests to run successfully. See: https://git.drupalcode.org/project/drupal/-/blob/9.0.x/core/profiles/sta... and https://git.drupalcode.org/project/drupal/-/raw/97811f7568833f1b3e14b77c...

Comments

shrop created an issue. See original summary.

shrop’s picture

shrop commented
Issue summary: View changes
Parent issue: » #3107871: [META] Drupal 9 release plan for Guardr

  • shrop committed 69ee0e1 on 8.x-1.x 
    Issue #3133296 by shrop: Restore GuardrTest.php back to what is...
shrop’s picture

shrop commented
Status: Active » Fixed

Completed changes in commit https://www.drupal.org/commitlog/commit/38618/69ee0e14e9ce32de9febef905b.... Pushed up to 8.x-1.x.

Noting that this file has the same static analysis errors found in core, so we can fix those later with future updates and possible help Drupal core.

⇒  drupal-check -ad web/profiles/contrib/guardr/tests/src/Functional/GuardrTest.php
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ------------------------------------------------------------------------------------------ 
  Line   GuardrTest.php                                                                            
 ------ ------------------------------------------------------------------------------------------ 
  103    Method Drupal\Tests\BrowserTestBase::assertRaw() invoked with 2 parameters, 1 required.   
  192    Access to an undefined property Drupal\Tests\guardr\Functional\GuardrTest::$dumpHeaders.  
 ------ ------------------------------------------------------------------------------------------ 

                                                                                                                        
 [ERROR] Found 2 errors                                                                                                 
                                                                                                                        

shrop@shrop-macbookpro:~/Sites/guardr-test|
⇒  drupal-check -ad web/core/profiles/standard/tests/src/Functional/StandardTest.php 
 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------- 
  Line   StandardTest.php                                                                              
 ------ ---------------------------------------------------------------------------------------------- 
  98     Method Drupal\Tests\BrowserTestBase::assertRaw() invoked with 2 parameters, 1 required.       
  187    Access to an undefined property Drupal\Tests\standard\Functional\StandardTest::$dumpHeaders.  
 ------ ---------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 2 errors

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.