We have 75 entities tagged to a term. Ordering them with drag and drop while the results are paginated is cumbersome.

I've created a patch that allows users to set the max number of entities to list.

I was debating if I should just patch the module to show all by default. EntityListBuilder sets the $limit to 50 by default. If you set it to "false" it will show all. Which seems appropriate for an ordering module such as this one. However, if there were a thousand entities tagged to a term, loading them all would probably not be ideal (WSOD potential).

So that's my current reasoning. Open to discussion.

Patch #3 sets a default of 50 if nothing has been set in the admin.

Issue fork nodeorder-3132575

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

xpersonas created an issue. See original summary.

xpersonas’s picture

StatusFileSize
new4.32 KB
xpersonas’s picture

StatusFileSize
new4.33 KB
xpersonas’s picture

Issue summary: View changes
davps’s picture

Version: 8.x-1.0-beta2 » 3.x-dev
Assigned: Unassigned » davps
Status: Active » Needs work

davps’s picture

Assigned: davps » Unassigned
Status: Needs work » Fixed

@xpersonas, thanks for help and patch. The patch has been updated to the current version.

  • davps committed c8aedf1a on 3.x
    Issue #3132575: Allow users to set max number of entities to prevent...

  • davps committed 52699e52 on 2.x
    Issue #3132575: Allow users to set max number of entities to prevent...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.