web/modules/contrib/encryption/src/EncryptionTrait.php (in context of class Drupal\encryption\EncryptionService) 45 Call to deprecated method randomBytes() of class Drupal\Component\Utility\Crypt. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use PHP's built-in random_bytes() function instead.
web/modules/contrib/encryption/src/EncryptionTrait.php (in context of class Drupal\encryption\EncryptionService) 84 Call to deprecated method hashEquals() of class Drupal\Component\Utility\Crypt. Deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use PHP's built-in hash_equals() function instead.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3132437-10.patch | 1.56 KB | Jaesin |
| #10 | interdiff-3132437_7-10.txt | 308 bytes | Jaesin |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
mo_farhaz commentedplease review.
Comment #3
gg4 commentedThis module's info.yml needs to be updated to account for this deprecation - #3070687: New 'core_version_requirement' key in info.yml files for modules, themes and profiles allows Composer semantic version constraints including specifying multiple major versions of core
Comment #4
gg4 commentedComment #5
gg4 commentedAdding requirement and version matching version constraint for Drupal Core to composer.json as well.
Comment #7
Jaesin commentedI don't think the module should require 8.8. It has been working as is since early in 8.0 and the functions we are changing to is from PHP 7.0 so just adding php >=7 and ext-openssl should do the trick.
Comment #8
Jaesin commentedFixes the empty interdiff.
Comment #10
Jaesin commentedI understand that we need to keep `core: 8.x` in order to keep compatibility with Drupal 8. If anyone knows this to be a myth, let me know.
Comment #11
gg4 commentedIIUC and as detailed in #3070687, if the module needs to support for Drupal < 8.8, then `core: 8.x` is still required.
I think the most compelling reason to drop support for older version of Drupal 8 is that core versions < 8.9 no longer receive security support and maintaining compatibility could be considered unnecessary and increase support overhead. Although, overhead would probably be minimal in this case of this module and the decision to drop support Drupal < 8.9 could always be deferred. Personally, I favor addressing this now as part of this issue (as it also simplifies the module's direct requirements a bit), but no strong opinions either way. #10 LGTM either way.
Comment #12
gg4 commentedAdditionally, testbot also does not supported versions of Drupal < 8.9 so we lose that safety net for older version.
Comment #14
Jaesin commentedI understand wanting to maintain the scope of support. Maybe we can get a topic started about that so others can weigh in on the subject.