Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Add core_version_requirement: ^8 || ^9 to vppr.info.yml to designate that the module is compatible with Drupal 9.
See https://www.drupal.org/node/3070687.
drupal-check & rector reports okay.
> drupal-check -ad modules/custom/vppr
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
> vendor/bin/rector process modules/custom/vppr --dry-run
Rector 0.8.x-dev@8896f0a
Config file: rector.yml
12/12 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] Rector is done!
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3131603-6.patch | 807 bytes | jaykandari |
Comments
Comment #2
jaykandariAdded a patch. Kindly Review.
Comment #3
ankush_03ankushgautam@GGN-199732-C02ZT1F1MD6V contrib % drupal-check vppr
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors
ankushgautam@GGN-199732-C02ZT1F1MD6V contrib % drupal-check -ad vppr
4/4 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
------ -----------------------------------------------------------------
Line src/VpprPermissions.php
------ -----------------------------------------------------------------
33 PHPDoc tag @param references unknown parameter: $entity_manager
Please fix it :
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_manager change it to * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
Otherwise looks good to me !
Comment #4
nehajyoti commentedApplying patch in #2 as of now to atleast make a 9.x version release. Another patch can be added to in this same issue regarding changes mentioned by AnkushGautam76.
Comment #5
ankush_03As per #3 there is no blocker in module only minor comment changes so marking it RTBC !
Comment #6
jaykandariUpdated the patch with recommendations in #3. Thanks @ankush. :)
Please review.
Comment #8
ankush_03Looks Good !
Comment #10
nehajyoti commentedComment #11
nehajyoti commentedComment #13
kristen polAdding missing tag.