Great module. The Content structure is awesome and very much like any Group Content plugins added to Groups.
Though I am encountering errors on menu add screens to groups and then adding links to menus if the menus are created automatically with a new group. So URLs like these are not working group/1/menu/add or when adding links to a menu (if it has been created with a group) group/4/menu/1/add-link. The error is as follows

InvalidArgumentException: The controller for URI "/group/1/menu/add" is not callable. in Drupal\Core\Controller\ControllerResolver->getControllerFromDefinition() (line 75 of core/lib/Drupal/Core/Controller/ControllerResolver.php).

Thanks

CommentFileSizeAuthor
#9 3130387-9.patch18.24 KBheddn
#3 group_content_menu-update-menu-controller-3130387-3.patch553 bytesgbeezus

Comments

Drupak created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Feel free to extend on the test cases that landed in #3130752: Add test coverage to cover this functionality. I can also manually reproduce this issue.

gbeezus’s picture

gbeezus commented
StatusFileSize
new group_content_menu-update-menu-controller-3130387-3.patch553 bytes

I was able to manually reproduce. I've attached a patch.

gbeezus’s picture

gbeezus commented
Status: Active » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue tags: +Needs tests

Can we get some additional test coverage on this? Even just adding a $this->drupalGet('/group/1/menu/add'); would probably trigger the error, no?

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work
eme’s picture

eme commented

It works indeed ! Adding new link is workable. Adding menu isn't. I'll post another issue.

For the test coverage, I thing that should be handled in another issue as well to get this fixed !

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Features/bug fixes should usually be added with test coverage to prove the problem is fixed or the new feature is functional.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new 3130387-9.patch18.24 KB

This fixes the issue identified here, plus a few other cases. No interdiff.

heddn credited devkinetic.

heddn credited kapilkumar0324.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: Errors when Adding menus to existing Groups and menu links to existing menus » Errors when managing menus and menu links on Groups

Re-titling

  • heddn committed 12bc466 on 8.x-1.x 
    Issue #3130387 by heddn, gbeezus, Drupak, devkinetic, kapilkumar0324,...
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Fixed
drupak’s picture

drupak commented

I am thankful to all of you. I can also confirm it works for me now.

Regards

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.