Comments

killes@www.drop.org created an issue. See original summary.

killes@www.drop.org’s picture

StatusFileSize
new2.4 KB

something like this

sharma.amitt16’s picture

Assigned: Unassigned » sharma.amitt16
sharma.amitt16’s picture

Status: Active » Needs review
StatusFileSize
new4.62 KB

killes@www.drop.org, I agree with the request. But in your code, you are adding header in the foreach() loop and fixed the headers in the array. But others may want to add more headers on such pages. So we can't hardcode this in the code itself.
So I have added a field on settings form for that so one can configure these from the backend. Not it is allowed to add multiple headers on settings form (admin/config/content/access_unpublished) and headers will be reflected on-page.

Status: Needs review » Needs work

The last submitted patch, 4: 3130346-4.patch, failed testing. View results

sharma.amitt16’s picture

Status: Needs work » Needs review
StatusFileSize
new4.7 KB

Fix for failed test cases.

Rkumar’s picture

Assigned: sharma.amitt16 » Unassigned
sharma.amitt16’s picture

@killes@www.drop.org @martin_klima Would you guys please review this?

chr.fritsch’s picture

StatusFileSize
new5.75 KB
new5.7 KB

Thanks for the work. I cleaned everything up a bit. Update hook is still missing

chr.fritsch’s picture

StatusFileSize
new6.3 KB
new560 bytes

With update hook

chr.fritsch’s picture

StatusFileSize
new6.43 KB

Rerolled

chr.fritsch’s picture

StatusFileSize
new9.04 KB
new3.06 KB

And now with a test

chr.fritsch’s picture

StatusFileSize
new10.1 KB
new1 KB

Uh, we have an error in D8.9. Lets quickly fix it

daniel.bosen’s picture

Status: Needs review » Reviewed & tested by the community

lgtm

  • chr.fritsch committed f64d192 on 8.x-1.x
    Issue #3130346 by chr.fritsch, sharma.amitt16, killes@www.drop.org,...
chr.fritsch’s picture

Status: Reviewed & tested by the community » Fixed

Done

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.