CommentFileSizeAuthor
#7 ckeditor_tableselection-drupal_9_readiness-3129952-7.patch375 bytessebastix
#2 ckeditor_tableselection-drupal_9_readiness-3129952-2.patch426 bytesandrewsizz

Comments

AndrewsizZ created an issue. See original summary.

andrewsizz’s picture

andrewsizz commented
Assigned: andrewsizz » Unassigned
Status: Active » Needs review
StatusFileSize
new ckeditor_tableselection-drupal_9_readiness-3129952-2.patch426 bytes

Please review patch

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

we still need the "core: 8" line according to https://www.drupal.org/node/3070687

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

sebastix’s picture

sebastix
Primary language Dutch
Location Breda, Netherlands
commented
StatusFileSize
new ckeditor_tableselection-drupal_9_readiness-3129952-7.patch375 bytes

Patch with core: 8.x used for version 8.x-1.0

elgandoz’s picture

elgandoz commented

Sebastian Hagens solution is better since it maintains <8.6 compatibility.
Since it has already been committed to dev, you should probably create a new ticket porting back legacy compatibility.

a.milkovsky’s picture

a.milkovsky
he/him
Location UTC +2
commented

Drupal 8.6 is deprecated.