FILE: ...h_api_glossary/src/Plugin/facets/processor/GlossaryAZAllItemsProcessor.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
41 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
41 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
--------------------------------------------------------------------------------

FILE: ...s/contrib/search_api_glossary/src/Plugin/search_api/processor/Glossary.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
179 | WARNING | t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead

CommentFileSizeAuthor
#2 3129553-2.patch1.6 KBmo_farhaz

Comments

mo_farhaz created an issue. See original summary.

mo_farhaz’s picture

Assigned: mo_farhaz » Unassigned
Status: Active » Needs review
StatusFileSize
new1.6 KB

please review.

kristen pol’s picture

Category: Bug report » Task
Status: Needs review » Reviewed & tested by the community

Thanks for the issue and patch!

I'm working on creating a Drupal 9 release and am reviewing all "needs review" issues in the process.

Confirmed that the patch still applies cleanly and modifies both:

src/Plugin/facets/processor/GlossaryAZAllItemsProcessor.php

and

src/Plugin/search_api/processor/Glossary.php

as expected.

The code looks okay and the change is simple, so I think this is fine to include in the next release. I'll probably be committing this today.

  • Kristen Pol committed 083ad05 on 8.x-4.x authored by mo_farhaz
    Issue #3129553 by mo_farhaz, Kristen Pol: t() calls should be avoided in...
kristen pol’s picture

Status: Reviewed & tested by the community » Fixed

Committed. Will be creating a new release shortly.

kristen pol’s picture

Status: Fixed » Closed (fixed)