Format Default Value

I just tried applying, but I had already applied https://www.drupal.org/project/date_popup/issues/3042555#comment-13825435 to fix error messages, so this patch fails for me with;

error: patch failed: src/DatePopupTrait.php:28
error: src/DatePopupTrait.php: patch does not apply

I manually edited the file with the patch changes and it indeed fixed the display of dates with relative defaults.

I was having trouble getting the date to display in the date popup widget even though the patch was functional on a real site.

However I just tested in DrupalPod and I couldn't reproduce my issue with the patch. The patch applied successfully and worked as desired in the following work flows:

Existing view:
1. Create a new view with the desired relative date in a exposed filter.
2. Apply the patch.
3. Clear cache
4. View has the relative dates converted in the date popup input field and the view is filtered by the dates.

New view:
1. Apply the patch.
2. Create a new view with the desired relative date in a exposed filter.
3. View has the relative dates converted in the date popup input field and the view is filtered by the dates.

I found one issue with the patch.

The "Value Type" radio buttons no longer matter. Regardless of whether I want relative dates or not, it still converts in the actual view.

The change should respect the Value Type setting.

Added a condition for checking whether the "Value Type" is equal to offset to the existing patch. Attached the updated patch.

+++ b/src/DatePopupTrait.php
@@ -2,11 +2,29 @@
+  protected function setDefaultValue(&$default_value) {

I'm not keen on this operating by reference, my preference would be to have it return a value and set that on the item.

Can we also add some type-hinting and return-types here.

This patch should address @larowlan's comments in #9.

I also re-worded some comments for clarity.

Thanks, I'll give this another look during my contrib contrib office hours next Wed

Thanks folks

This will go out as 8.x-1.2