drupal-check results on commit hash: dfe824455494263c7e71f74a71bc839a9cd6c209

------ --------------------------------------------------- 
  Line   src/WebformEncryptSubmissionStorage.php
 ------ --------------------------------------------------- 
  53     Parameter $entity_manager of method Drupal\webform_encrypt\WebformEncryptSubmissionStorage::__construct() has typehint with deprecated interface Drupal\Core\Entity\EntityManagerInterface:
         in drupal:8.0.0 and is removed from drupal:9.0.0.
 ------ --------------------------------------------------- 

 [ERROR] Found 1 error
CommentFileSizeAuthor
#2 3129298-2.patch2.8 KBsuzymasri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

suzymasri created an issue. See original summary.

suzymasri’s picture

suzymasri
Location Greece
CreditAttribution: suzymasri at Pfizer, Inc. commented
FileSize
3129298-2.patch2.8 KB
suzymasri’s picture

suzymasri
Location Greece
CreditAttribution: suzymasri at Pfizer, Inc. commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 3129298-2.patch, failed testing. View results

Manuel Garcia’s picture

Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commented
Status: Needs work » Needs review

Looks like the failures are in HEAD as well, so we should fix those first in my opinion: #3133536: Tests fail in HEAD

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented

pushed #3133536: Tests fail in HEAD and kicked retest here.

  • vijaycs85 committed 40a690c on 8.x-1.x authored by suzymasri 
    Issue #3129298 by suzymasri, Manuel Garcia: Drupal 9 Readiness
vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Fixed

green! committed. thank you both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.