When the user has been blocked on REST request it is not possible to clear the flood via the GUI. It is however possible to clear the flood via the drush command `drush flood_unblock:all`
When logging in via REST two records exist in the flood table:
- user.failed_login_ip
- user.http_login
It would appear that the module is only deleting user.failed_login_ip and not user.http_login via the GUI
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | failed-rest-3124512-7.patch | 8.42 KB | batigolix |
| #6 | failed-rest-3124512-6.patch | 4.36 KB | batigolix |
| #5 | failed-rest-3124512-5.patch | 3.85 KB | batigolix |
| #3 | failed-rest-3124512-3.patch | 773 bytes | batigolix |
Issue fork flood_unblock-3124512
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
batigolixI'll have a crack at it
Comment #3
batigolixThere seem to be 3 events that end up in the flood table: user.failed_login_user, user.http_login (the rest basic auth login) and user.failed_login_ip
user.http_login was not covered by flood_unblock. I extended the query so it is covered as well. Please check the patch.
There may be more events, but I couldn't find a list of them in the core user module.
Comment #4
batigolixBummer, the form submit deleting items from flood tables is broken.
Comment #5
batigolixThis should be better. I think there is more work to be done to remove code duplication, but that could be left for another issue.
Comment #6
batigolixOne more tiny improvement
Comment #7
batigolixok, ok, i did remove the duplicate code as well
and that's it: no more patches for today ;)
Comment #8
batigolixI see that this issue is probably not compatible with the changes here: #2928007: Support external Flood (Redis, etc.)
Comment #9
batigolixComment #13
fabianderijkThanks @batigolix, this is now in the 3.0.x branch!