t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead

LGTM

Needs tweaking as PathautoTestHelperTrait trait already brings in StringTranslationTrait (and hence there's a clash).

Created re-roll as #2 patch doesn't apply
Resolved some phpcs issues.
And removed use of StringTranslationTrait where PathautoTestHelperTrait is already used in the patch.

Will review patch mentioned in #5

I reviewed patch 3124089-5.patch mentioned in #5. All StringTranslationTrait are removed from the code files where PathautoTestHelperTrait trait is already used. Other coding standard issues are remaining in codebase but it can be solved in another separate issue. This issue can be move to RTBC. Moving to RTBC.

There are about 3 actual changes in PathautoTestHelperTrait that shouldn't use t() at all but just string concentation or something. Anything else is unrelated generated coding standards and addition of traits that already exist through the class hierarchy.

1. +++ b/src/Form/PatternEditForm.php
   @@ -9,12 +9,15 @@ use Drupal\Core\Form\FormStateInterface;
     */
    class PatternEditForm extends EntityForm {
    
   +  use StringTranslationTrait;
   +
   

   EntityForm extends FormBase which has the trait already.

2. +++ b/src/Form/PatternEditForm.php
   @@ -110,7 +113,7 @@ class PatternEditForm extends EntityForm {
    
   -    // if there is no type yet, stop here.
   +    // If there is no type yet, stop here.
        if ($this->entity->getType()) {
    
          $alias_type = $this->entity->getAliasType();
   @@ -121,7 +124,10 @@ class PatternEditForm extends EntityForm {
   
   @@ -121,7 +124,10 @@ class PatternEditForm extends EntityForm {
            '#default_value' => $this->entity->getPattern(),
            '#size' => 65,
            '#maxlength' => 1280,
   -        '#element_validate' => ['token_element_validate', 'pathauto_pattern_validate'],
   +        '#element_validate' => [
   +          'token_element_validate',
   +          'pathauto_pattern_validate',
   +        ],
   

   lots of unrelated changes in this file.

3. +++ b/src/PathautoPatternListBuilder.php
   @@ -4,12 +4,15 @@ namespace Drupal\pathauto;
     * Provides a listing of Pathauto pattern entities.
     */
    class PathautoPatternListBuilder extends DraggableListBuilder {
    
   +  use StringTranslationTrait;
   +
   

   this already exists too.

SIX YEARS