Drupal 9 deprecated code report [#3124027]

Class Drupal\Tests\menu_link_modal\FunctionalJavascript\MenuLinkModalTest extends deprecated class Drupal\FunctionalJavascriptTests\JavascriptTestBase. Deprecated in drupal:8.6.0 and is removed from drupal:9.0.0. Use \Drupal\FunctionalJavascriptTests\WebDriverTestBase instead

Call to method setUp() of deprecated class Drupal\Tests\BrowserTestBase. Deprecated in drupal:8.6.0 and is removed from drupal:9.0.0. Use \Drupal\FunctionalJavascriptTests\WebDriverTestBase instead

Call to deprecated function entity_load_multiple_by_properties(). Deprecated in drupal:8.0.0 and is removed from drupal:9.0.0. Use the entity type storage's loadByProperties() method.

Add core_version_requirement: ^8 || ^9 to menu_link_modal.info.yml to designate that the module is compatible with Drupal 9. See https://www.drupal.org/node/3070687.

Comment	File	Size	Author
#31	interdiff_29-31.txt	1.71 KB	vsujeetkumar
#31	3124027_31.patch	4.66 KB	vsujeetkumar
#29	3124027-29.patch	3.96 KB	neograph734
#27	3124027-27.patch	3.89 KB	neograph734
#25	3124027-25.patch	3.75 KB	neograph734
#23	3124027-23.patch	2.81 KB	suresh prabhu parkala
#22	3124027_22.patch	2.76 KB	codersukanta
#22	interdiff_18-22.txt	898 bytes	codersukanta
#18	interdiff_16-18.txt	467 bytes	vsujeetkumar
#18	3124027_18.patch	2.84 KB	vsujeetkumar
#16	interdiff_14-16.txt	1.52 KB	vsujeetkumar
#16	3124027_16.patch	2.57 KB	vsujeetkumar
#14	3124027-14.patch	2.17 KB	nitesh624
#13	3124027-13.patch	1.9 KB	nitesh624
#12	3124027-11.patch	1.95 KB	nitesh624
#10	3124027-10.patch	1.95 KB	nitesh624
#8	interdiff-5-8.txt	674 bytes	salah1
#8	3124027-8.patch	1.95 KB	salah1
#5	3124027-5.patch	1.55 KB	rajandro
#2	3124027-2.patch	1.46 KB	Varun Rao

Issue fork menu_link_modal-3124027

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3124027-drupal-9-deprecated changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

1 April 2020 at 09:12

Varun Rao created an issue. See original summary.

Comment #2

Varun Rao commented 1 April 2020 at 09:39

Assigned:	Varun Rao	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	3124027-2.patch	1.46 KB

Please review the patch.

Comment #3

1 April 2020 at 09:42

Status:

Needs review

» Needs work

The last submitted patch, 2: 3124027-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #4

rajandro commented 24 April 2020 at 11:40

Assigned:

Unassigned

» rajandro

Comment #5

rajandro commented 4 June 2020 at 06:18

Status	File	Size
new	3124027-5.patch	1.55 KB

Adding fixes for Drupal 9 deprecated code report

Comment #6

rajandro commented 27 April 2020 at 15:02

Assigned:	rajandro	» Unassigned
Status:	Needs work	» Needs review

Comment #7

27 April 2020 at 15:07

Status:

Needs review

» Needs work

The last submitted patch, 5: 3124027-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #8

salah1

VA, U.S

commented 9 May 2020 at 15:03

Status:

Needs work

» Needs review

Status	File	Size
new	3124027-8.patch	1.95 KB
new	interdiff-5-8.txt	674 bytes

This patch attempts to fix the failures on #5 because response headers are not available from the new driver(DrupalSelenium2Driver)
for more see: https://www.drupal.org/project/drupal/issues/2827014

Comment #9

nitesh624

he/him

English

Ranchi, India

commented 15 May 2020 at 11:56

Assigned:

Unassigned

» nitesh624

Comment #10

nitesh624

he/him

English

Ranchi, India

commented 15 May 2020 at 12:29

Status	File	Size
new	3124027-10.patch	1.95 KB

Comment #11

15 May 2020 at 12:34

Status:

Needs review

» Needs work

The last submitted patch, 10: 3124027-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #12

nitesh624

he/him

English

Ranchi, India

commented 15 May 2020 at 12:39

Status	File	Size
new	3124027-11.patch	1.95 KB

Comment #13

nitesh624

he/him

English

Ranchi, India

commented 15 May 2020 at 13:51

Status	File	Size
new	3124027-13.patch	1.9 KB

Comment #14

nitesh624

he/him

English

Ranchi, India

commented 15 May 2020 at 14:03

Status	File	Size
new	3124027-14.patch	2.17 KB

Comment #15

nitesh624

he/him

English

Ranchi, India

commented 18 May 2020 at 15:32

Assigned:

nitesh624

» Unassigned

Comment #16

vsujeetkumar commented 21 May 2020 at 11:19

Status:

Needs work

» Needs review

Status	File	Size
new	3124027_16.patch	2.57 KB
new	interdiff_14-16.txt	1.52 KB

Test Fixed, Please review.

Comment #17

21 May 2020 at 11:24

Status:

Needs review

» Needs work

The last submitted patch, 16: 3124027_16.patch, failed testing. View results

Comment #18

vsujeetkumar commented 21 May 2020 at 12:09

Status:

Needs work

» Needs review

Status	File	Size
new	3124027_18.patch	2.84 KB
new	interdiff_16-18.txt	467 bytes

Fixed test, Please review

Comment #19

21 May 2020 at 12:18

Status:

Needs review

» Needs work

The last submitted patch, 18: 3124027_18.patch, failed testing. View results

Comment #20

codersukanta commented 22 May 2020 at 07:30

Assigned:	Unassigned	» codersukanta
Issue tags:		+DIACWMay2020

Comment #21

kristen pol

she/her

English

Santa Cruz, CA, USA

commented 22 May 2020 at 23:20

Issue tags:

+Drupal 9 porting weekend

Presuming this is for Drupal 9 porting weekend since last comment was during that time.

Comment #22

codersukanta commented 26 May 2020 at 19:41

Assigned:	codersukanta	» Unassigned
Status:	Needs work	» Needs review

Status	File	Size
new	interdiff_18-22.txt	898 bytes
new	3124027_22.patch	2.76 KB

Patch added.

Comment #23

suresh prabhu parkala commented 3 June 2020 at 07:40

Status	File	Size
new	3124027-23.patch	2.81 KB

Patch did not apply. Re-rolled patch. Please review.

Comment #24

3 June 2020 at 07:44

Status:

Needs review

» Needs work

The last submitted patch, 23: 3124027-23.patch, failed testing. View results

Comment #25

neograph734

he/him

Netherlands

commented 1 March 2021 at 21:31

Status:

Needs work

» Needs review

Status	File	Size
new	3124027-25.patch	3.75 KB

14 files were hidden/shown/deleted

Status	File	Size
hidden	3124027-2.patch	1.46 KB
hidden	3124027-5.patch	1.55 KB
hidden	3124027-8.patch	1.95 KB
hidden	interdiff-5-8.txt	674 bytes
hidden	3124027-10.patch	1.95 KB
hidden	3124027-11.patch	1.95 KB
hidden	3124027-13.patch	1.9 KB
hidden	3124027-14.patch	2.17 KB
hidden	3124027_16.patch	2.57 KB
hidden	interdiff_14-16.txt	1.52 KB
hidden	3124027_18.patch	2.84 KB
hidden	interdiff_16-18.txt	467 bytes
hidden	interdiff_18-22.txt	898 bytes
hidden	3124027_22.patch	2.76 KB

Making the patch up-to-date with all deprecations (hopefully).

Comment #26

1 March 2021 at 21:39

Status:

Needs review

» Needs work

The last submitted patch, 25: 3124027-25.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #27

neograph734

he/him

Netherlands

commented 1 March 2021 at 22:36

Status:

Needs work

» Needs review

Status	File	Size
new	3124027-27.patch	3.89 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	3124027-25.patch	3.75 KB

Comment #28

1 March 2021 at 22:41

Status:

Needs review

» Needs work

The last submitted patch, 27: 3124027-27.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Comment #29

neograph734

he/him

Netherlands

commented 1 March 2021 at 23:24

Status:

Needs work

» Needs review

Status	File	Size
new	3124027-29.patch	3.96 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	3124027-27.patch	3.89 KB

Looks like the details section needs to be expanded as well with submitForm. Still not sure why the test will not run in Drupal 9 though.

Comment #30

1 March 2021 at 23:28

Status:

Needs review

» Needs work

The last submitted patch, 29: 3124027-29.patch, failed testing. View results

Comment #31

vsujeetkumar commented 2 March 2021 at 06:08

Status:

Needs work

» Needs review

Status	File	Size
new	3124027_31.patch	4.66 KB
new	interdiff_29-31.txt	1.71 KB

Fixing tests.

Comment #32

neograph734

he/him

Netherlands

commented 2 March 2021 at 07:30

Status:

Needs review

» Reviewed & tested by the community

Thanks vsujeetkumar, looking good.

Comment #33

16 July 2021 at 15:02

the_turk made their first commit to this issue’s fork.

Comment #34

kuhikar commented 28 July 2021 at 11:36

@miteshmap,

Kindly help to release 3.x version of this module.

Please do check: Drupal 8 end-of-life on November 2, 2021 : https://www.drupal.org/psa-2021-2021-06-29

commented 30 July 2021 at 09:29

Thank you all, I have created a merge request. I will merge it and create a new release - 2.0.

Comment #38

30 July 2021 at 09:34

miteshmap committed 14a3628 on 8.x-2.x authored by vsujeetkumar

Issue #3124027 by vsujeetkumar, miteshmap: Drupal 9 deprecated code...

Comment #39

miteshmap

Gujarati

commented 30 July 2021 at 09:43

Status:

Reviewed & tested by the community

» Fixed

created new branch 8.x-2.x and the release is 8.x-2.0.

Comment #40

13 August 2021 at 09:44

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Drupal 9 deprecated code report

Issue fork menu_link_modal-3124027

Comments

Child issues