------ ---------------------------------------------------------------------- 
  Line   modules/bazaarvoice_products/bazaarvoice_products.module              
 ------ ---------------------------------------------------------------------- 
  136    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------- 
  Line   modules/bazaarvoice_reviews/src/Form/AddReviewForm.php                
 ------ ---------------------------------------------------------------------- 
  84     Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
  93     Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
  100    Call to deprecated function drupal_set_message():                     
         in drupal:8.5.0 and is removed from drupal:9.0.0.                     
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.  
 ------ ---------------------------------------------------------------------- 

CommentFileSizeAuthor
#6 3123988-6.patch11.48 KBkamkejj
#3 3123988-3.patch12.21 KBjaperry
#2 3123988-2.patch2.57 KBsahana _n

Comments

Sahana _N created an issue. See original summary.

sahana _n’s picture

Status: Active » Needs review
StatusFileSize
new2.57 KB

please review the patch.

japerry’s picture

StatusFileSize
new12.21 KB

There is quite a few things that need to be updated. Specifically, the review system has some deprecations in Drupal 8.8. This unfortunately means the minimum version supported would be 8.8.

Before committing, probably should get sign-off that we want 8.8 to be the minimum supported. If you aren't on 8.8, it won't update this code, it'll leave you on the prior version without issue.

japerry’s picture

Title: Remove deprecated code » Drupal 9 Compatibility
Issue tags: +D9 readiness
kristen pol’s picture

Issue tags: -D9 readiness +Drupal 9 compatibility
kamkejj’s picture

StatusFileSize
new11.48 KB

Re-rolled patch #4.

kamkejj’s picture

Used this patch to create the 3.0.0-rc1 release. I think we want the 2.x version to remain Drupal 8 compatible.

sorlov’s picture

These changes doesn't prevent 2,x version from being compatible with Drupal 8

so I'd say better to push these changes to 2.x-dev version

  • kamkejj committed e2af455 on 8.x-2.x
    git commit -m 'Issue #3123988 by Sahana _N, kamkejj, japerry: Drupal 9...
kamkejj’s picture

Merged to 2.x

kamkejj’s picture

Status: Needs review » Fixed
kamkejj’s picture

Status: Fixed » Closed (fixed)