------ ----------------------------------------------------------------------
Line modules/bazaarvoice_products/bazaarvoice_products.module
------ ----------------------------------------------------------------------
136 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------
------ ----------------------------------------------------------------------
Line modules/bazaarvoice_reviews/src/Form/AddReviewForm.php
------ ----------------------------------------------------------------------
84 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
93 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
100 Call to deprecated function drupal_set_message():
in drupal:8.5.0 and is removed from drupal:9.0.0.
Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
------ ----------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3123988-6.patch | 11.48 KB | kamkejj |
| #3 | 3123988-3.patch | 12.21 KB | japerry |
| #2 | 3123988-2.patch | 2.57 KB | sahana _n |
Comments
Comment #2
sahana _n commentedplease review the patch.
Comment #3
japerryThere is quite a few things that need to be updated. Specifically, the review system has some deprecations in Drupal 8.8. This unfortunately means the minimum version supported would be 8.8.
Before committing, probably should get sign-off that we want 8.8 to be the minimum supported. If you aren't on 8.8, it won't update this code, it'll leave you on the prior version without issue.
Comment #4
japerryComment #5
kristen polComment #6
kamkejj commentedRe-rolled patch #4.
Comment #7
kamkejj commentedUsed this patch to create the 3.0.0-rc1 release. I think we want the 2.x version to remain Drupal 8 compatible.
Comment #8
sorlov commentedThese changes doesn't prevent 2,x version from being compatible with Drupal 8
so I'd say better to push these changes to 2.x-dev version
Comment #10
kamkejj commentedMerged to 2.x
Comment #11
kamkejj commentedComment #12
kamkejj commented