[Slick 1.9.0] Fix ROWS setting default value & description (ROWS needs to be 0 instead of 1) / slick-slide has unnecessary wrappers

Thank you.

The library default value, and its docs sets rows to 1:
http://kenwheeler.github.io/slick/

If we changed it, it will break pre 1.8.1.

There is a different minimum value and logic to this between branches.

I don't know how to deal with it. We cannot simply change that number.

FYI, sometimes I prefer 1.6, and your patch will break that version.

If you have a better idea to handle this, please update.

This is not module bug, just library latest change, so worth a Task.

Yes, warning is less troublesome. Unless you have time to cross-check against versions.

Basically I don't know yet how to deal with different versions. I just checked, even the latest release still sets this to 1.

If made different, I have no time to verify against or simply read the library code if any is hard-coded or not with this value. No time to debug if any issue like what you have now across versions.

If anyone have free time and are confident to verify, feel free to proceed.

However if you should change it after confident checks, consider a hook update to change default optionset with the relevant line at slick.optionset.default.yml and likely the entire stored optionsets with careful checks such as those using this option bigger > 1, and those without, aside from your lines.

And any other place, if any. I hope not.

OK. Let's keep it open for a while, then.

Added tags for easy finding. Thanks for sharing.

That is helpful. Thank you.

Just few nits:

• !empty() to isset() for just in case 0 is considered empty. Ignore if not.
• drupal_set_message() was deprecated in favor of Messenger service. There is a sample at that SlickFormBase form at ::save().
• t() to $this->t() unless for static methods.
• https://www.drupal.org/project/slick/issues/3123787 to an accessible link.

Thank you. Just one last bit.

I forgot to detail, sorry. The link should be put in a variable:
<a href=":url">...</a>

Then pass the value at the second param of t().

There is a similar sample on ::save too.

Truly sorry for terrible delay.

This needs better handles, perhaps via JS for immediate hints.
Currently it is a bit confusing, and doesn't validate the installed version.

However it is better than broken :)

Added a space and minor message to avoid back and forth confusion:
, or leave it as if not using >1.9.0

Committed. Thank you for contribution and patience.