Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.1. How do you build the theme and/or react components?
2. How do you set up the site end-to-end?
| Comment | File | Size | Author |
|---|---|---|---|
| #17 | 3123153-17.patch | 617.37 KB | Irisibk |
| #12 | 3123153-12.patch | 1.75 KB | markconroy |
| #8 | 3123153-9.patch | 280.63 KB | markconroy |
Comments
Comment #3
nerdsteinPer Slack from @sumitmadan:
Comment #4
nerdsteinOne idea could be to add post-update hooks to the composer.json. This will rerun the various steps after code is updated
Comment #5
nerdsteinOther documentation needs:
1. Loading the distribution and installing it
2. Loading the Tugboat CLI tool locally, configuring the module
3. A contribution guide and "how to"
Comment #7
nerdsteinI was able to connect with @irisibk, she had the following guidance on the theme:
Comment #8
markconroy CreditAttribution: markconroy at Annertech commentedHere's a patch with some documentation to get the theme running. I have the React part running and the gulp tasks running via this README.md, but can't see any CSS on my page, which I presume is because I don't have a version of Drupal running with this so the CSS/JS libraries can't be seen.
Perhaps you can test this patch with your installed version, @nerdstein
Also, I couldn't get the gulp tasks to work when using Yarn, so switched to using NPM. To get it to work we need to use a newer version of the natives package, so this patch also adds that - we are now using Natives@1.1.6 (it is suggested _not_ to use natives at all, but that's another story, at the moment it's a dependency of gulp so looks like it's needed).
Comment #9
markconroy CreditAttribution: markconroy at Annertech commentedComment #10
nerdsteinThis looks like a great start. I'm going to merge the patch now and intentionally leave this open to address the other documentation cases.
Merging this in will allow me to test the frontend changes you commented on and offer more feedback.
Comment #12
markconroy CreditAttribution: markconroy at Annertech commentedAttaching an updated patch with notes about using NVM, rebuilding node-sass, and adding a
.nvmrcfile.Comment #13
markconroy CreditAttribution: markconroy at Annertech commentedComment #15
nerdsteinLooks great - this is merged. Moving back to needs work for remaining docs
Comment #16
nerdsteinWe need to include instructions on how to load projects. (reminder to self)
Comment #17
Irisibk CreditAttribution: Irisibk at CivicActions commentedHere's a patch that
1. Updates gulp & gulp tasks from v3 -> v4
2. Cleans up npm vulnerabilities.
3. Adds gulp tasks to the readme file.
4. Removes the yarn.lock file since npm works fine. (Please let me know if you want to retain the ability to use yarn. I'll be happy to update the yarn.lock file)
I'm afraid the patch is a bit large. Much of it is package-lock updates.
Comment #19
nerdsteinThis has been reviewed, merged. Thank you, Iris!
I am going to move this back to "needs work" so we do the actual documentation part.
Comment #20
Kristen PolWhen @nerdstein and I were looking at the dev server he noticed that there was at least one missing file from the commit above so he asked me to take a look and check the entire commit to make sure there weren't others and to create a patch to fix it. I put it in a different issue so as to not cloud this issue too much with various comments:
#3163579: Missing .sass-lint.yml file in the commit for issue 3123153