CommentFileSizeAuthor
#6 svg_image-3122818-6.patch1.24 KBdouggreen
#5 svg_info-3122818-5.patch1.24 KBdouggreen
#4 3122818-4.patch772 byteswodzik
#2 3122818-2.patch342 bytesneslee canil pinto

Comments

Neslee Canil Pinto created an issue. See original summary.

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3122818-2.patch342 bytes
imyaro’s picture

imyaro commented
Status: Needs review » Postponed

Module is not tested for d9 yet.
Formally all compatibility issues resolved, but I didn't tried it myself.
This patch should be applied only when 9.x branch and first 9x beta release will be ready to be created.

wodzik’s picture

wodzik commented
StatusFileSize
new 3122818-4.patch772 bytes
douggreen’s picture

douggreen commented
StatusFileSize
new svg_info-3122818-5.patch1.24 KB

Updated patch sets also the core_version_requirement for svg_image_responsive

douggreen’s picture

douggreen commented
StatusFileSize
new svg_image-3122818-6.patch1.24 KB

doh! this just renames the patch file to use the correct module name.

gaëlg’s picture

gaëlg
he/him
Primary language French
Location Lille, France
commented
Status: Postponed » Reviewed & tested by the community

D9 core beta2 is out and a stable release is planned for June 3rd, so I guess this is not postponed anymore.

I applied patch #6 on latest dev. Then drupal-check finds no errors.

The patch is simple and looks good. Theoretically there's no reason that the module would not work with Drupal 9 as soon as deprecation notices are fixed, as D9 = D8 - deprecated code. So it looks RTBC to me.

extect’s picture

extect commented

Confirm the patch is working great on latest 9.x-rc1.
+1 to get this committed.

  • zvse committed 979cf9e on 8.x-1.x authored by douggreen 
    Issue #3122818 by douggreen, Neslee Canil Pinto, wodzik, zvse:...
imyaro’s picture

imyaro commented
Status: Reviewed & tested by the community » Fixed

Patch pushed, thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.