Closed (fixed)
Project:
Webform Views Integration
Version:
8.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
27 Mar 2020 at 07:50 UTC
Updated:
30 Jul 2020 at 23:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
suresh prabhu parkala commentedPlease review!
Comment #3
lilit_ghazaryan commentedComment #4
luke.leberLooks like there's one reference to `entity.manager` left.
Comment #5
mradcliffeTests are failing so back to Needs work.
It looks like the default for this module is to test in PHP 5.5, which won't work anymore.
Comment #6
lilit_ghazaryan commentedComment #7
lilit_ghazaryan commentedComment #8
lilit_ghazaryan commentedComment #9
luke.leberI can confirm that:
+1 from me!
Comment #10
scott_euser commentedPatch working well, testing within D9 env. Only issue I can see is test module fails:
tests/modules/webform_views_test/webform_views_test.info.yml
Should remove from the test module:
core: 8.xAnd should add:
core_version_requirement: ^8.8 || ^9Comment #11
suresh prabhu parkala commentedupdated as per #10. Please review.
Comment #12
scott_euser commentedGreat thanks, I've triggered the tests to rerun but the change looks good to me.
Comment #13
scott_euser commentedLooks like tests are failing
Comment #14
Akash_Daimari commentedThe patch #11 is working for me Drupal 9.0.0
Comment #15
rivimeyLooks like the test fails are related to the exception handling:
Declaration of Drupal\webform\EventSubscriber\WebformExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) should be compatible with Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\ExceptionEvent $event)Comment #16
acbramley commentedThose errors come from the webform module. We need to require 6.x or later since that is where webform's 9.x compatibility lives.
All tests with
Comment #17
acbramley commentedFixed ordering of use statements.
Comment #18
jibranThe only way the test will run will be if we commit the info file changes first other than this is RTBC.
Comment #20
acbramley commentedFixed! Thanks everyone