Comments

suresh prabhu parkala’s picture

Status: Active » Needs review
StatusFileSize
new6.11 KB

Please review!

lilit_ghazaryan’s picture

Issue summary: View changes
Issue tags: +Drupal 9 porting weekend
StatusFileSize
new6.43 KB
luke.leber’s picture

Looks like there's one reference to `entity.manager` left.

mradcliffe’s picture

Status: Needs review » Needs work

Tests are failing so back to Needs work.

It looks like the default for this module is to test in PHP 5.5, which won't work anymore.

lilit_ghazaryan’s picture

StatusFileSize
new18.79 KB
lilit_ghazaryan’s picture

Status: Needs work » Needs review
lilit_ghazaryan’s picture

StatusFileSize
new12.83 KB
luke.leber’s picture

StatusFileSize
new73.48 KB

I can confirm that:

  • #6 resolves all deprecation outlined by drupal-check.
  • I am able to install the webform_views module on 9.0.x-dev after patching the webform module to be Drupal 9 compatible.
  • I am able to create a simple view of the contact form submissions

+1 from me!

scott_euser’s picture

Status: Needs review » Needs work

Patch working well, testing within D9 env. Only issue I can see is test module fails:
tests/modules/webform_views_test/webform_views_test.info.yml

Should remove from the test module:
core: 8.x

And should add:
core_version_requirement: ^8.8 || ^9

suresh prabhu parkala’s picture

Status: Needs work » Needs review
StatusFileSize
new19.31 KB
new398 bytes

updated as per #10. Please review.

scott_euser’s picture

Status: Needs review » Reviewed & tested by the community

Great thanks, I've triggered the tests to rerun but the change looks good to me.

scott_euser’s picture

Status: Reviewed & tested by the community » Needs work

Looks like tests are failing

Akash_Daimari’s picture

The patch #11 is working for me Drupal 9.0.0

rivimey’s picture

Looks like the test fails are related to the exception handling:
Declaration of Drupal\webform\EventSubscriber\WebformExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\GetResponseForExceptionEvent $event) should be compatible with Drupal\Core\EventSubscriber\DefaultExceptionHtmlSubscriber::on403(Symfony\Component\HttpKernel\Event\ExceptionEvent $event)

acbramley’s picture

Status: Needs work » Needs review
StatusFileSize
new19.38 KB
new215 bytes

Those errors come from the webform module. We need to require 6.x or later since that is where webform's 9.x compatibility lives.

All tests with

acbramley’s picture

StatusFileSize
new19.51 KB
new947 bytes

Fixed ordering of use statements.

jibran’s picture

Status: Needs review » Reviewed & tested by the community

The only way the test will run will be if we commit the info file changes first other than this is RTBC.

  • acbramley committed ca52a1d on 8.x-5.x
    Issue #3122790 by acbramley, Lilit_Ghazaryan, Suresh Prabhu Parkala,...
acbramley’s picture

Assigned: suresh prabhu parkala » Unassigned
Status: Reviewed & tested by the community » Fixed

Fixed! Thanks everyone

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.