| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3122456-11.patch | 1.55 KB | mvbaalen |
| #8 | 3122456-8.patch | 1.94 KB | nils.destoop |
| #6 | 3122456-6.patch | 397 bytes | ankush_03 |
| #3 | 3122456-3.patch | 778 bytes | sahana _n |
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | 3122456-11.patch | 1.55 KB | mvbaalen |
| #8 | 3122456-8.patch | 1.94 KB | nils.destoop |
| #6 | 3122456-6.patch | 397 bytes | ankush_03 |
| #3 | 3122456-3.patch | 778 bytes | sahana _n |
Comments
Comment #2
sahana _n commentedComment #3
sahana _n commentedPlease review the patch.
Comment #5
sahana _n commentedComment #6
ankush_03Re-roll patch core version in composer json file is not required.
Comment #7
ankush_03Comment #8
nils.destoop commentedI still had some fatal errors. The getLinkRelationTypes method is renamed too getLinkRelationType and the setting only allows a string instead of an array.
Important, this patch will probably be not compatible with older versions of Drupal 8.
Comment #9
burningdog commentedI have an "About Us" content type and an image field. When viewing the "About Us" node in JSON:API, the
imageDerivativesproperty did show (as expected) for the image field, with the expected values (2 image styles, in my case). However, when viewing the related entity, the image field (typefile--file) I got the errors which @nils.destoop describes.Applying his patch to
src/Normalizer/LinkCollectionNormalizer.php(on version4.0.0ofconsumer_image_styles) got it working for me on Drupal 9.1.0.Comment #10
burningdog commentedThe specific errors I got were:
When that was fixed, then:
When that was fixed, then:
Warning: array_unique() expects parameter 1 to be array, null given in Drupal\consumer_image_styles\Normalizer\LinkCollectionNormalizer::Drupal\consumer_image_styles\Normalizer\{closure}() (line 173 of /Users/rs/Sites/back9/back9-drupal/web/modules/contrib/consumer_image_styles/src/Normalizer/LinkCollectionNormalizer.php).:These are all fixed by the patch in #8.
Comment #11
mvbaalen commentedThanks for supplying a patch that fixes this!
The patch supplied in #8 did not apply in 4.0.0 (non dev) version in Drupal 9, because the ^8 || ^9 version requirement is already in there.
Re-rolled the patch for that version.
Comment #12
el1_1el commentedMaybe I'm missing something on priority and status, but after an 8->9 upgrade my site wont build with a fatal error from this issue. Marked as a bug and critical.
#11 fixes the issue. Thanks!
Comment #13
marcvangendAgree with #12, and thanks for the patches! Let's get this committed.
Comment #14
makkus183 commented#11 fixes the issue and saved my deployment! Thx a lot!
Comment #15
nickdjmTested #11 with v4.0.0 and it resolved the issue for me as well.
Thanks for the patch!
Comment #16
pebosi commentedWorks for me too, please create a new release.
Comment #17
e0ipsoThanks to all involved with reporting, writing a patch, and testing. This should be fixed and released now.