Comments

realityloop created an issue. See original summary.

sahana _n’s picture

Assigned: Unassigned » sahana _n
sahana _n’s picture

Status: Active » Needs review
StatusFileSize
new1.79 KB

Please review the patch.

segovia94’s picture

Looks like the failing tests are due to changing the assertions

-    $this->assertInternalType('int', $actual[0]->body['You are number']);
-    $this->assertInternalType('string', $actual[0]->body['Where am I']);
-    $this->assertInternalType('boolean', $actual[0]->body['World of number two']);
-    $this->assertInternalType('string', $actual[0]->body['Question']);
-    $this->assertInternalType('float', $actual[0]->body['Michael']);
+    $this->assertIsInt($actual[0]->body['You are number']);
+    $this->assertIsString($actual[0]->body['Where am I']);
+    $this->assertIsBool( $actual[0]->body['World of number two']);
+    $this->assertIsString( $actual[0]->body['Question']);
+    $this->assertIsFloat($actual[0]->body['Michael']);

The indenting is also off here:

-    "galbar/jsonpath": "^1.0"
+    "galbar/jsonpath": "^1.0",
+      "drupal/core": "^8 || ^9"
segovia94’s picture

StatusFileSize
new793 bytes

This should hopefully pass tests.

e0ipso’s picture

Thanks for the patch!

  • e0ipso committed 18b0d85 on 8.x-2.x authored by segovia94
    Issue #3122455 by segovia94, Sahana _N, realityloop, e0ipso: Drupal 9...
e0ipso’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.