It looks like the module has no deprecated code usages, so we just need to mark it as compatible with D9.
So, add core_version_requirement: ^8 || ^9 to all info.yml files, https://www.drupal.org/node/3070687.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3120746-9.patch | 4.04 KB | chr.fritsch |
| #8 | 3120746-8.patch | 3.55 KB | chr.fritsch |
| #5 | password_policy-n3120746-5.patch | 457 bytes | damienmckenna |
| #5 | password_policy-n3120746-5.interdiff.txt | 350 bytes | damienmckenna |
| #2 | updated-info-file.patch | 382 bytes | sahana _n |
Comments
Comment #2
sahana _n commentedPlease review the patch.
Comment #3
aohrvetpv commentedThanks for the patch, Sahana_N. Since there is a Drupal 9 beta, maybe before committing we should test this module with the Drupal 9 beta, to be sure that it is actually compatible and not just hypothetically compatible.
Comment #4
damienmckennaThe info file also says:
- drupal:system (>=8.5.0)This line needs to be removed so that it will then also work with Drupal 9 and not be limited by Composer to only install on D8.
Comment #5
damienmckennaThis makes the change as suggested in #4, I'm going to test it locally to confirm it works with a composer build.
Comment #6
damienmckennaComment #7
damienmckennaSo the patch doesn't fix the problem when using composer_patches because it doesn't provide a way of modifying the data exposed by Drupal's composer integration.
In short, it should work fine when the patch is committed.
Comment #8
chr.fritschcore_version_requirement needs to be added to all info files
Comment #9
chr.fritschMissed the test module..
Comment #10
nerdsteinThis looks good. Thanks. I'll get it merged
Comment #12
nerdsteinThis is fixed. I'll be researching a new release
Comment #13
klemendev commentedThank you! :)