It looks like the module has no deprecated code usages, so we just need to mark it as compatible with D9.

So, add core_version_requirement: ^8 || ^9 to all info.yml files, https://www.drupal.org/node/3070687.

Comments

Sahana _N created an issue. See original summary.

sahana _n’s picture

Status: Active » Needs review
StatusFileSize
new382 bytes

Please review the patch.

aohrvetpv’s picture

Thanks for the patch, Sahana_N. Since there is a Drupal 9 beta, maybe before committing we should test this module with the Drupal 9 beta, to be sure that it is actually compatible and not just hypothetically compatible.

damienmckenna’s picture

Status: Needs review » Needs work

The info file also says:
- drupal:system (>=8.5.0)
This line needs to be removed so that it will then also work with Drupal 9 and not be limited by Composer to only install on D8.

damienmckenna’s picture

Status: Needs work » Needs review
StatusFileSize
new350 bytes
new457 bytes

This makes the change as suggested in #4, I'm going to test it locally to confirm it works with a composer build.

damienmckenna’s picture

Issue tags: +Drupal 9 compatibility
damienmckenna’s picture

So the patch doesn't fix the problem when using composer_patches because it doesn't provide a way of modifying the data exposed by Drupal's composer integration.

In short, it should work fine when the patch is committed.

chr.fritsch’s picture

StatusFileSize
new3.55 KB

core_version_requirement needs to be added to all info files

chr.fritsch’s picture

StatusFileSize
new4.04 KB

Missed the test module..

nerdstein’s picture

Status: Needs review » Reviewed & tested by the community

This looks good. Thanks. I'll get it merged

  • nerdstein committed 7258ae6 on 8.x-3.x authored by chr.fritsch
    Issue #3120746 by chr.fritsch, DamienMcKenna, Sahana _N, AohRveTPV,...
nerdstein’s picture

Status: Reviewed & tested by the community » Fixed

This is fixed. I'll be researching a new release

klemendev’s picture

Thank you! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.