Variable comment in menu-local-tasks.html.twig refers to wrong variable

@humbl_dev

I applied the patch on a clean D9 install, and everything looks fine except that it looks like the hash needs to be updated again to pass ConfirmClassyCopiesTest.

Patch fails on D9 attached screenshot.

Hi @humbl_dev, @jerseychesse,
I have updated the same patch and screenshots for the Drupal 9.1 dev version. Please have a look. Can you please tell me how you guys generated the hash key for menu-local-tasks.html.twig file, I have tried but no luck. So finally I have used the '1e0112bb83f6073f6fc44a94b43dd74b' and it was passed in Drupal 9.1 dev.

Hi @humbl_dev,
Please have a look and let me know if there are any issues

Hi @Ramya Balasubramanian,

Patch looks good to me there is no error found.
moving this to RTBC.

Thanks for working on this issue.

@shaktik, posting screenshots of your codebase or CLI does not advance the issue, since the automated testing infrastructure tells us whether the patch applies correctly. You can also validate whether the patch works on multiple branches by clicking the "Add test/retest" link under the patch.

Similarly for @Raunak.singh, we don't need screenshots of tests passing for the same reason. DrupalCI will tell us that too. :)

I've removed credits for screenshots of the above CLI results. In the future, you can get credit for issues by reading the issue to understand its purpose, and posting your review or testing of that purpose.

Thank you both and I hope this helps you to provide reviews for your next issue.

Meanwhile, this patch is fixing a documentation bug, so it is allowed even for Classy which has a strict BC policy. I also confirmed with @bnjmnm that adding the hash to the test like this is the correct solution for a situation where an allowed change is being made to the actual Classy template. Good work!

The one thing we need to do is make sure we update the other themes that also have this bug. After applying the patch, I still find a couple places with the same docs bug, in Umami, Stable 9, and the System module's own template:

[ibnsina:maintainer | Wed 14:06:50] $ grep -r "secondary: HTML list items representing primary tasks." *
core/profiles/demo_umami/themes/umami/templates/components/navigation/menu-local-tasks.html.twig: * - secondary: HTML list items representing primary tasks.
core/modules/system/templates/menu-local-tasks.html.twig: * - secondary: HTML list items representing primary tasks.
core/themes/stable9/templates/navigation/menu-local-tasks.html.twig: * - secondary: HTML list items representing primary tasks.

Let's fix those too. Thanks!

Hi @xjm,
I have updated the same docs bug, in Umami, Stable 9, and the System module's own template. Updated the patch and please have a look.

#22 looks good ,it corrects the secondary variable comment in menu-local-tasks.html.twig
( core/modules/system/templates/menu-local-tasks.html.twig
core/profiles/demo_umami/themes/umami/templates/components/navigation/menu-local-tasks.html.twig
core/themes/bartik/templates/classy/navigation/menu-local-tasks.html.twig
core/themes/claro/templates/menu-local-tasks.html.twig
core/themes/classy/templates/navigation/menu-local-tasks.html.twig
core/themes/seven/templates/menu-local-tasks.html.twig
core/themes/stable/templates/navigation/menu-local-tasks.html.twig
core/themes/stable9/templates/navigation/menu-local-tasks.html.twig )
RTBC

Committed and pushed 469ed5d230 to 9.2.x and d2debc75ec to 9.1.x. Thanks!

@ranjith_kumar_k_u please read #20 re-posting of screen shots. Similarly removed credit.

Now that Olivero has landed we need to update that as well. I've done that on commit.

diff --git a/core/themes/olivero/templates/navigation/menu-local-tasks.html.twig b/core/themes/olivero/templates/navigation/menu-local-tasks.html.twig
index 4a138bd016..ad43d52a07 100644
--- a/core/themes/olivero/templates/navigation/menu-local-tasks.html.twig
+++ b/core/themes/olivero/templates/navigation/menu-local-tasks.html.twig
@@ -5,7 +5,7 @@
  *
  * Available variables:
  * - primary: HTML list items representing primary tasks.
- * - secondary: HTML list items representing primary tasks.
+ * - secondary: HTML list items representing secondary tasks.
  *
  * Each item in these variables (primary and secondary) can be individually
  * themed in menu-local-task.html.twig.