Change the link color to distinguish the other normal texts

CommentFileSizeAuthor
#6 3119149-6.patch377 bytesavani.addweb
#5 screenshot 2020-03-11 19.25.42.png891.57 KByas
#4 3119149-4.patch218 bytesavani.addweb
#2 3118450-8.patch218 bytesavani.addweb

Comments

Avani.addweb created an issue. See original summary.

avani.addweb’s picture

avani.addweb commented
StatusFileSize
new 3118450-8.patch218 bytes

@yas, Changed link color and attached patch for that. Please check and let me know your views for the same.

avani.addweb’s picture

avani.addweb commented
avani.addweb’s picture

avani.addweb commented
Status: Active » Needs review
StatusFileSize
new 3119149-4.patch218 bytes

@yas, Please ignore the above patch and check this new one.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work
StatusFileSize
new screenshot 2020-03-11 19.25.42.png891.57 KB

@avaniaddweb

Thank you for the refactoring. Can you check my comments below?

42.png

↑ Or, can we keep the current color scheme as the black color (#333) and red arrow as it is in the header row in the listing table ? That means, no color change is only applied to a header row, which would be better look & feel.

avani.addweb’s picture

avani.addweb commented
Status: Needs work » Needs review
StatusFileSize
new 3119149-6.patch377 bytes

@yas
I have made changes in the attached patch, please check and let me know if any changes required.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@avaniaddweb

Thank you for the update. This is even better so looks good to me now. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed 5778599 on 8.x-1.x authored by Avani.addweb 
    Issue #3119149 by Avani.addweb, yas: Change the link color to...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.