Passing the $glue and $pieces parameters in reverse order to implode has been deprecated since PHP 7.4.
See https://www.php.net/manual/en/migration74.deprecated.php.

CommentFileSizeAuthor
taxonomy_manager-php-7.4.patch747 bytesjacob.embree

Comments

jacob.embree created an issue. See original summary.

hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented
Status: Needs review » Reviewed & tested by the community

The patch looks good, and should be simple enough to commit without tests.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed
hargobind’s picture

hargobind
he/him
Location Austin, Texas
commented

Glad to see this committed, and a new release!

FYI, the release page for 1.1 doesn't include this issue. It would be good to add it since people may want to know for sure that this release includes PHP 7.2/3/4 compatibility.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Thanks @hargobind.
Release notes have been updated.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.